From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] arch-powerpc.inc: use default value of TUNE_PKGARCH
Date: Fri, 9 Mar 2012 10:45:33 -0600 [thread overview]
Message-ID: <4F5A33AD.4060800@windriver.com> (raw)
In-Reply-To: <1331237734.3006.33.camel@ted>
On 3/8/12 2:15 PM, Richard Purdie wrote:
> On Tue, 2012-03-06 at 17:20 -0600, Matthew McClintock wrote:
>> We can use the default value for TUNE_PKGARCH, and now we just
>> append "-nf" if TARGET_FPU is fpu-soft
>>
>> Signed-off-by: Matthew McClintock<msm@freescale.com>
>> ---
>> meta/conf/machine/include/powerpc/arch-powerpc.inc | 6 ++----
>> 1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>> index c9b2829..abd72ed 100644
>> --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc
>> +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>> @@ -18,10 +18,8 @@ TARGET_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "soft", "", d)}
>>
>> ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-efs']]}"
>>
>> -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}"
>> -
>> -PPCPKGARCH = "${TUNE_ARCH}${PPCPKGSFX_FPU}"
>> -TUNE_PKGARCH ?= "${PPCPKGARCH}"
>> +PPCPKGSFX_FPU = "${@['', '-nf'][bb.data.getVar('TARGET_FPU',d,1) in ['fpu-soft']]}"
>> +TUNE_PKGARCH_append = "${PPCPKGSFX_FPU}"
>
> Can we please do d.getVar(xxx, True) and not bb.data and ,1 :)
This was originally done with a check for fpu-hard and not fpu-soft to ensure
that fpu-soft became the default value when one or the other wasn't set.
I don't know if it really matters which is used, but that is why it was done
that way.
--Mark
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2012-03-09 16:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 23:20 [PATCH] arch-powerpc.inc: use default value of TUNE_PKGARCH Matthew McClintock
2012-03-07 9:11 ` [PATCH] arch-powerpc.inc: use default value ofTUNE_PKGARCH Eibach, Dirk
2012-03-07 17:41 ` [PATCH] arch-powerpc.inc: use default value of TUNE_PKGARCH Richard Purdie
2012-03-10 16:30 ` McClintock Matthew-B29882
2012-03-08 20:15 ` Richard Purdie
2012-03-08 21:03 ` [PATCH v2] " Matthew McClintock
2012-03-09 16:45 ` Mark Hatle [this message]
2012-03-09 16:50 ` [PATCH] " McClintock Matthew-B29882
-- strict thread matches above, loose matches on Subject: below --
2012-03-22 16:38 [PATCH] powerpc: fix overly aggressive TUNE_PKGARCH set Richard Purdie
2012-03-22 16:53 ` [PATCH] arch-powerpc.inc: use default value of TUNE_PKGARCH Matthew McClintock
2012-03-22 17:54 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A33AD.4060800@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox