Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] adt-installer: Corrected wrong environment file names.
Date: Mon, 12 Mar 2012 10:40:11 -0700	[thread overview]
Message-ID: <4F5E34FB.2050409@linux.intel.com> (raw)
In-Reply-To: <324c375ed3e7c0fb061b52c9dd6a57afdfe4f5fa.1331085934.git.lianhao.lu@intel.com>

On 03/06/2012 06:06 PM, Lianhao Lu wrote:
> [YOCTO #2055]
> 1. Corrected the wrong environment file name for powerpc.
>
> 2. Removed unnecessary variables in adt_installer.conf.
>
> Signed-off-by: Lianhao Lu<lianhao.lu@intel.com>
> ---
>   .../adt-installer/scripts/adt_installer_internal   |    2 ++
>   .../installer/adt-installer_1.0.bb                 |    5 +----
>   2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-devtools/installer/adt-installer/scripts/adt_installer_internal b/meta/recipes-devtools/installer/adt-installer/scripts/adt_installer_internal
> index 6201095..684dc88 100755
> --- a/meta/recipes-devtools/installer/adt-installer/scripts/adt_installer_internal
> +++ b/meta/recipes-devtools/installer/adt-installer/scripts/adt_installer_internal
> @@ -175,6 +175,8 @@ check_result
>   echo_info "Updating environment script with target sysroot location."
>   if [ "$1" == "x86"  ]; then
>     env_filename=`ls $INSTALL_FOLDER/environment-setup-i586*`
> +elif [ "$1" == "ppc" ]; then
> +  env_filename=`ls $INSTALL_FOLDER/environment-setup-powerpc*`
>   else
>     env_filename=`ls $INSTALL_FOLDER/environment-setup-$1*`
>   fi
> diff --git a/meta/recipes-devtools/installer/adt-installer_1.0.bb b/meta/recipes-devtools/installer/adt-installer_1.0.bb
> index 340349d..27937d9 100644
> --- a/meta/recipes-devtools/installer/adt-installer_1.0.bb
> +++ b/meta/recipes-devtools/installer/adt-installer_1.0.bb
> @@ -30,7 +30,7 @@ ALLOW_EMPTY = "1"
>
>   PACKAGES = ""
>
> -PR = "r6"
> +PR = "r7"
>
>   ADT_DEPLOY = "${TMPDIR}/deploy/sdk/"
>   ADT_DIR = "${WORKDIR}/adt-installer/"
> @@ -68,9 +68,6 @@ fakeroot do_populate_adt () {
>   	cp -r scripts ${ADT_DIR}/
>   	cp adt_installer ${ADT_DIR}
>   	cp adt_installer.conf ${ADT_DIR}
> -	echo 'YOCTOADT_VERSION=${SDK_VERSION}'>  ${ADT_DIR}/temp.conf
> -        cat ${ADT_DIR}/adt_installer.conf>>  ${ADT_DIR}/temp.conf
> -        mv ${ADT_DIR}/temp.conf ${ADT_DIR}/adt_installer.conf
>   	sed -i -e 's#YOCTOADT_VERSION#${SDK_VERSION}#' ${ADT_DIR}/adt_installer.conf
>           echo 'SDK_VENDOR=${SDK_VENDOR}'>>  ${ADT_DIR}/scripts/data_define
>           echo 'INSTALL_FOLDER=${SDKPATH}'>>  ${ADT_DIR}/scripts/data_define

Merged into OE-Core

Thanks
	Sau!



      reply	other threads:[~2012-03-12 17:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-07  2:06 [PATCH 0/1] fixed errors in adt-installer Lianhao Lu
2012-03-07  2:06 ` [PATCH 1/1] adt-installer: Corrected wrong environment file names Lianhao Lu
2012-03-12 17:40   ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5E34FB.2050409@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox