Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>
Subject: Re: [PATCH 5/6] ncurses: fix build when ENABLE_WIDEC is not set
Date: Wed, 14 Mar 2012 07:52:59 -0700	[thread overview]
Message-ID: <4F60B0CB.3090504@linux.intel.com> (raw)
In-Reply-To: <22f0c46dcba251287bcc3848c1537ad943c53788.1331685330.git.paul.eggleton@linux.intel.com>



On 03/13/2012 05:36 PM, Paul Eggleton wrote:
> If wide character support is disabled (as it is with poky-tiny, for
> example) then we won't have libncursesw.so.*, so skip moving these files
> in that case. (Fixes a regression introduced in OE-Core revision
> ccd370ab147b78de7a5bd74818f755f4d3ca6d81).
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>

Perfect, thanks Paul. Poky-tiny is now on the Yocto autobuilder which
should help catch when things like this creep in going forward.

--
Darren

> ---
>  meta/recipes-core/ncurses/ncurses.inc |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
> index e450868..fe2c3e4 100644
> --- a/meta/recipes-core/ncurses/ncurses.inc
> +++ b/meta/recipes-core/ncurses/ncurses.inc
> @@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://ncurses/base/version.c;beginline=1;endline=27;md5=cbc
>  SECTION = "libs"
>  DEPENDS = "ncurses-native"
>  DEPENDS_virtclass-native = ""
> -INC_PR = "r5"
> +INC_PR = "r6"
>  
>  inherit autotools binconfig multilib_header
>  
> @@ -185,7 +185,8 @@ shell_do_install() {
>              # case will skip this code
>              mkdir ${D}${base_libdir}
>              mv ${D}${libdir}/libncurses.so.* ${D}${base_libdir}
> -            mv ${D}${libdir}/libncursesw.so.* ${D}${base_libdir}
> +            ! ${ENABLE_WIDEC} || \
> +                mv ${D}${libdir}/libncursesw.so.* ${D}${base_libdir}
>  
>              mv ${D}${libdir}/libtinfo.so.* ${D}${base_libdir}
>              rm ${D}${libdir}/libtinfo.so

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel



  reply	other threads:[~2012-03-14 15:02 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-14  0:36 [PATCH 0/6] Misc build failure fixes Paul Eggleton
2012-03-14  0:36 ` [PATCH 1/6] scripts/bitbake: ensure user is in build directory Paul Eggleton
2012-03-14 14:52   ` Darren Hart
2012-03-14 15:09     ` Paul Eggleton
2012-03-14 15:19       ` Darren Hart
2012-03-15  0:30   ` Andreas Oberritter
2012-03-15 23:09     ` Paul Eggleton
2012-03-16  0:20       ` Andreas Oberritter
2012-03-16 10:56         ` Paul Eggleton
2012-03-16 11:55           ` VIJAY KUMAR
2012-03-16 12:19             ` Paul Eggleton
2012-03-18 15:07           ` Andreas Oberritter
2012-04-02 20:00   ` Khem Raj
2012-04-02 20:12     ` Paul Eggleton
2012-04-02 20:32       ` Chris Larson
2012-04-02 20:56         ` Paul Eggleton
2012-03-14  0:36 ` [PATCH 2/6] pulseaudio: add X library dependencies Paul Eggleton
2012-03-14  0:36 ` [PATCH 3/6] gst-plugins-bad: disable directfb in configure Paul Eggleton
2012-03-14  0:36 ` [PATCH 4/6] mx: add dependencies Paul Eggleton
2012-03-14  0:36 ` [PATCH 5/6] ncurses: fix build when ENABLE_WIDEC is not set Paul Eggleton
2012-03-14 14:52   ` Darren Hart [this message]
2012-03-14  0:36 ` [PATCH 6/6] linux-yocto-tiny: add dependency on xz-native Paul Eggleton
2012-03-14  8:21   ` Koen Kooi
2012-03-14  8:32     ` Paul Eggleton
2012-03-14 12:29       ` Bruce Ashfield
2012-03-14 12:39         ` Paul Eggleton
2012-03-14 12:59           ` Bruce Ashfield
2012-03-14 13:03             ` Paul Eggleton
2012-03-14 13:12               ` Bruce Ashfield
2012-03-14 14:55                 ` Darren Hart
2012-03-14 13:18 ` [PATCH 0/6] Misc build failure fixes Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F60B0CB.3090504@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox