From: Graeme Gregory <gg@slimlogic.co.uk>
To: openembedded-core@lists.openembedded.org
Subject: Re: what is meaning of "SRC_URI_append_whatever +=" ??
Date: Wed, 21 Mar 2012 10:51:33 +0000 [thread overview]
Message-ID: <4F69B2B5.1010607@slimlogic.co.uk> (raw)
In-Reply-To: <101A2F63-917B-40EA-809F-E42FF0C1DE14@dominion.thruhere.net>
On 21/03/2012 10:46, Koen Kooi wrote:
> Op 21 mrt. 2012, om 11:28 heeft Robert P. J. Day het volgende geschreven:
>
>> On Wed, 21 Mar 2012, Robert P. J. Day wrote:
>>
>>> still perusing the very basics of oe-core and grepping madly, came
>>> across the following oddity:
>>>
>>> $ grep -r SRC_URI_append *
>>> ... snip ...
>>> bitbake/doc/manual/usermanual.xml:SRC_URI_append_1.0.7+ = "file://some_patch_which_the_new_versions_need.patch;patch=1"</screen></para>
>>> meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append += "file://use-includedir.patch \
>>> meta/recipes-support/libcroco/libcroco_0.6.3.bb:SRC_URI_append = " file://croco.patch;apply=yes "
>>> ... snip ...
>>>
>>> AIUI, there are two (common) variations for extending SRC_URI. the
>>> straightforward unconditional way:
>>>
>>> SRC_URI += ... blah blah ...
>>>
>>> or if you need to make it conditional, then there's
>>>
>>> SRC_URI_append_thingy = "whatever"
>>>
>>> so what's with the latter two entries above?
>>>
>>> meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append += "file://use-includedir.patch \
>>> meta/recipes-support/libcroco/libcroco_0.6.3.bb:SRC_URI_append = " file://croco.patch;apply=yes "
>>>
>>> is there some subtlety i'm missing here? why would one ever use
>>> either of:
>>>
>>> SRC_URI_append += "..." (looks redundant)
>>> SRC_URI_append = "..." (why not just SRC_URI +=?)
>>>
>>> can i just assume those are typoes?
>> following up on my own post, i decided to scan the entire oe-core
>> tree:
>>
>> $ grep -r "_append +=" *
>> meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append += "file://use-includedir.patch \
>> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-dev_append += "${bindir}/rpcgen ${libdir}/*_nonshared.a \
>> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-staticdev_append += "${libdir}/*.a ${base_libdir}/*.a"
>> meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
>> $
>>
>> and i thought i'd look for another pattern as well:
>>
>> $ grep -r "_append_.*+=" *
>> meta/recipes-graphics/tslib/tslib_1.0.bb:SRC_URI_append_qemumips += " file://32bitBE-support.patch"
>> meta/recipes-graphics/tslib/tslib_1.0.bb:SRC_URI_append_qemuppc += " file://32bitBE-support.patch"
>> meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb:SRC_URI_append_poky += " file://owl-menu.patch;apply=yes "
>> $
>>
>> of course, if all of the above is perfectly valid, i'm going to be
>> embarrassed.
>
> AFAICT '_append +=' is completely bogus.
>
I beleive its valid to do
BLAH_append = "spanner"
BLAH_append += "toolbox"
then final result is BLAH_append variable is "spanner toolbox" then the
overrides happen.
Graeme
next prev parent reply other threads:[~2012-03-21 11:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 10:22 what is meaning of "SRC_URI_append_whatever +=" ?? Robert P. J. Day
2012-03-21 10:28 ` Robert P. J. Day
2012-03-21 10:46 ` Koen Kooi
2012-03-21 10:51 ` Graeme Gregory [this message]
2012-03-21 11:25 ` Robert P. J. Day
2012-03-21 12:08 ` Richard Purdie
2012-03-21 14:03 ` Chris Larson
2012-03-21 15:05 ` Robert P. J. Day
2012-03-21 11:11 ` Phil Blundell
2012-03-21 12:11 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F69B2B5.1010607@slimlogic.co.uk \
--to=gg@slimlogic.co.uk \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox