From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Denys Dmytriyenko <denys@ti.com>
Subject: Re: [PATCH] bitbake.conf: fix distro-less failure expanding FILESPATH
Date: Thu, 22 Mar 2012 10:34:14 -0700 [thread overview]
Message-ID: <4F6B6296.6080800@linux.intel.com> (raw)
In-Reply-To: <1332379983-2512-1-git-send-email-denis@denix.org>
On 03/21/2012 06:33 PM, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko<denys@ti.com>
>
> If DISTRO is not set, FILESPATH becomes littered with directories like
> files/${DISTRO} etc. It won't bomb until you try to eval it - i.e.
> manipulating FILESPATH directly with .= works fine, but calling e.g.
> base_set_filespath() throws this:
>
> ERROR: Failure expanding variable FILESPATH, expression was ${@blah} which
> triggered exception SyntaxError: EOL while scanning string literal (FILESPATH,
> line 1)
>
> Signed-off-by: Denys Dmytriyenko<denys@ti.com>
> ---
> meta/conf/bitbake.conf | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 17d2f26..16e72e4 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -637,7 +637,7 @@ AUTO_LIBNAME_PKGS = "${PACKAGES}"
> # This works for functions as well, they are really just environment variables.
> # Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
> OVERRIDES = "${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:forcevariable"
> -DISTROOVERRIDES ?= "${DISTRO}"
> +DISTROOVERRIDES ?= "${@d.getVar('DISTRO', True) or ''}"
> MACHINEOVERRIDES ?= "${MACHINE}"
> MACHINEOVERRIDES[vardepsexclude] = "MACHINE"
>
Merged into OE-Core
Thanks
Sau!
prev parent reply other threads:[~2012-03-22 17:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 1:33 [PATCH] bitbake.conf: fix distro-less failure expanding FILESPATH Denys Dmytriyenko
2012-03-22 17:34 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6B6296.6080800@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=denys@ti.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox