Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/4] module.bbclass: sync pkg_post{inst, rm} with kernel.bbclass
Date: Fri, 23 Mar 2012 18:58:07 +0100	[thread overview]
Message-ID: <4F6CB9AF.8090809@opendreambox.org> (raw)
In-Reply-To: <6382DE52-47CF-478A-A10A-26F27EF1AE06@dominion.thruhere.net>

On 23.03.2012 18:20, Koen Kooi wrote:
> 
> Op 23 mrt. 2012, om 17:37 heeft Andreas Oberritter het volgende geschreven:
> 
>> * Run depmod when the rootfs gets generated.
>>
>> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
>> ---
>> meta/classes/module.bbclass |    9 +++++----
>> 1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/classes/module.bbclass b/meta/classes/module.bbclass
>> index 53c16b7..e370b24 100644
>> --- a/meta/classes/module.bbclass
>> +++ b/meta/classes/module.bbclass
>> @@ -37,15 +37,16 @@ module_do_install() {
>> }
>>
>> pkg_postinst_append () {
>> -	if [ -n "$D" ]; then
>> -		exit 1
>> -	fi
>> +if [ -n "$D" ]; then
>> +	${HOST_PREFIX}depmod -A -b $D -F ${STAGING_KERNEL_DIR}/System.map-${KERNEL_VERSION} ${KERNEL_VERSION}
>> +else
>> 	depmod -a
>> 	update-modules || true
>> +fi
> 
> That encodes host system paths into the package, which is not a good thing for tools like narcissus and hob.

So should we remove the same lines from kernel.bbclass?

Regards,
Andreas



  reply	other threads:[~2012-03-23 18:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23 16:37 [PATCH 1/4] procps: use update-alternatives for pwdx, pgrep and watch Andreas Oberritter
2012-03-23 16:37 ` [PATCH 2/4] module.bbclass: sync pkg_post{inst, rm} with kernel.bbclass Andreas Oberritter
2012-03-23 17:20   ` Koen Kooi
2012-03-23 17:58     ` Andreas Oberritter [this message]
2012-03-23 18:20       ` Koen Kooi
2012-03-23 18:32         ` Richard Purdie
2012-03-23 17:39   ` Richard Purdie
2012-03-23 18:00     ` Andreas Oberritter
2012-03-23 16:37 ` [PATCH 3/4] sysvinit: use update-alternatives for mountpoint and runlevel Andreas Oberritter
2012-03-23 16:37 ` [PATCH 4/4] ppp: drop unneeded pkg-postinst Andreas Oberritter
2012-04-03 21:53 ` [PATCH 1/4] procps: use update-alternatives for pwdx, pgrep and watch Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6CB9AF.8090809@opendreambox.org \
    --to=obi@opendreambox.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox