Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Martin Jansa <martin.jansa@gmail.com>
Subject: Re: [PATCH 2/6] kernel.bbclass: use symlinks for modutils files
Date: Mon, 26 Mar 2012 11:46:48 -0700	[thread overview]
Message-ID: <4F70B998.3070405@linux.intel.com> (raw)
In-Reply-To: <4e31dfddbb238cd5e3c2ce19a49996e113419212.1332507302.git.Martin.Jansa@gmail.com>

What is the motivation?

On 03/23/2012 05:56 AM, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  meta/classes/kernel.bbclass |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 975ae13..54ed7f7 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -407,16 +407,14 @@ python populate_packages_prepend () {
>  		# appropriate modprobe commands to the postinst
>  		autoload = d.getVar('module_autoload_%s' % basename, True)
>  		if autoload:
> -			name = '%s/etc/modutils/%s' % (dvar, basename)
> -			f = open(name, 'w')
> -			for m in autoload.split():
> -				f.write('%s\n' % m)
> -			f.close()
>  			name = '%s/etc/modules-load.d/%s.conf' % (dvar, basename)
>  			f = open(name, 'w')
>  			for m in autoload.split():
>  				f.write('%s\n' % m)
>  			f.close()
> +			modutils_name = '%s/etc/modutils/%s' % (dvar, basename)
> +			modutils_target = '../modules-load.d/%s.conf' % (basename)
> +			os.symlink(modutils_target, modutils_name)

This basically undoes what was added in 1/2 and replaces it with
symblinks right?

If so, just do it as symlinks in the first place.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel



  reply	other threads:[~2012-03-26 18:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23 12:56 [PATCH 0/6] kernel.bbclass updates Martin Jansa
2012-03-23 12:56 ` [PATCH 1/6] kernel.bbclass: populate /etc/modules-load.d/ with module_autoload entries too Martin Jansa
2012-03-23 23:00   ` Andreas Oberritter
2012-03-23 23:11     ` Martin Jansa
2012-03-26 11:25       ` Richard Purdie
2012-03-26 18:44   ` Darren Hart
2012-03-23 12:56 ` [PATCH 2/6] kernel.bbclass: use symlinks for modutils files Martin Jansa
2012-03-26 18:46   ` Darren Hart [this message]
2012-03-26 18:58     ` Martin Jansa
2012-03-26 22:05     ` Richard Purdie
2012-03-23 12:56 ` [PATCH 3/6] kernel.bbclass: use better number for KERNEL_PRIORITY Martin Jansa
2012-03-23 12:56 ` [PATCH 4/6] kernel.bbclass: fix extra + in kernelrelease Martin Jansa
2012-03-23 13:24   ` Bruce Ashfield
2012-03-23 13:31     ` Martin Jansa
2012-03-26 16:02       ` Martin Jansa
2012-03-26 16:05         ` Martin Jansa
2012-03-26 16:25         ` Bruce Ashfield
2012-03-26 17:29           ` [PATCH] kernel.bbclass: touch .scmversion also in ${S} Martin Jansa
2012-03-26 18:32             ` Bruce Ashfield
2012-03-23 12:56 ` [PATCH 5/6] update-modules: update script to read /etc/modules-load.d/ directory Martin Jansa
2012-03-23 14:37   ` [PATCHv2 " Martin Jansa
2012-03-23 12:56 ` [PATCH 6/6] kernel.bbclass: don't create /etc/modutils/* Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F70B998.3070405@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox