Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] webkit: Fix build with gcc-4.7
Date: Wed, 04 Apr 2012 09:54:05 -0700	[thread overview]
Message-ID: <4F7C7CAD.9050408@linux.intel.com> (raw)
In-Reply-To: <1333135290-13424-1-git-send-email-raj.khem@gmail.com>

On 03/30/2012 12:21 PM, Khem Raj wrote:
> Include unistd.h for all linux and not
> just for android.
>
> Signed-off-by: Khem Raj<raj.khem@gmail.com>
> ---
>   .../recipes-sato/webkit/files/function-scope.patch |   21 ++++++++++++++++++++
>   meta/recipes-sato/webkit/webkit-gtk_svn.bb         |    3 +-
>   2 files changed, 23 insertions(+), 1 deletions(-)
>   create mode 100644 meta/recipes-sato/webkit/files/function-scope.patch
>
> diff --git a/meta/recipes-sato/webkit/files/function-scope.patch b/meta/recipes-sato/webkit/files/function-scope.patch
> new file mode 100644
> index 0000000..a20a805
> --- /dev/null
> +++ b/meta/recipes-sato/webkit/files/function-scope.patch
> @@ -0,0 +1,21 @@
> +we need to include unistd.h on all linux platforms therefore
> +extend the conditional inclusion accordingly
> +
> +This gets proper declation of sleep() into the source file
> +
> +Signed-off-by: Khem Raj<raj.khem@gmail.com>
> +
> +Upstream-Status: Pending
> +Index: webkit-gtk-1.7.2+svnr101488-r3/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp
> +===================================================================
> +--- webkit-gtk-1.7.2+svnr101488-r3.orig/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp	2012-03-30 12:11:04.912613223 -0700
> ++++ webkit-gtk-1.7.2+svnr101488-r3/Tools/DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp	2012-03-30 12:14:21.840622752 -0700
> +@@ -29,7 +29,7 @@
> + #include<assert.h>
> + #include<string.h>
> +
> +-#if defined(ANDROID)
> ++#if defined(__linux__)
> + #include<unistd.h>
> + #endif
> +
> diff --git a/meta/recipes-sato/webkit/webkit-gtk_svn.bb b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> index 9181c2c..7db573d 100644
> --- a/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> +++ b/meta/recipes-sato/webkit/webkit-gtk_svn.bb
> @@ -15,7 +15,7 @@ SRCREV_FORMAT = "source"
>
>   SRCREV = "101488"
>   PV = "1.7.2+svnr${SRCPV}"
> -PR = "r3"
> +PR = "r4"
>
>   SRC_URI = "\
>     svn://svn.webkit.org/repository/webkit/trunk/;module=Source;proto=http;name=source \
> @@ -28,6 +28,7 @@ SRC_URI = "\
>     file://GNUmakefile.am \
>     file://gtk-doc.make \
>     file://nodolt.patch \
> +  file://function-scope.patch \
>    "
>
>   S = "${WORKDIR}/"

Merged this along with the 2 QT patches for gcc to OE-Core

Thanks
	Sau!



      reply	other threads:[~2012-04-04 17:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30 19:21 [PATCH] webkit: Fix build with gcc-4.7 Khem Raj
2012-04-04 16:54 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7C7CAD.9050408@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox