Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Stefan Herbrechtsmeier <stefan@herbrechtsmeier.net>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] linux-firmware: keep version string in libertas firmware
Date: Tue, 10 Apr 2012 15:18:30 +0200	[thread overview]
Message-ID: <4F843326.2@herbrechtsmeier.net> (raw)
In-Reply-To: <9F60AC4C-D174-4A8C-930A-6397842763AF@dominion.thruhere.net>

Am 06.04.2012 15:31, schrieb Koen Kooi:
> Op 5 apr. 2012 om 20:17 heeft Saul Wold<sgw@linux.intel.com>  het volgende geschreven:
>> On 04/05/2012 03:36 AM, Stefan Herbrechtsmeier wrote:
>>> Recent Linux kernel tries to load the libertas firmware with the version
>>> string in its name first. This results in a delayed firmware load on
>>> system boot. Keep the default libertas firmware name and add a link for
>>> older driver versions.
>>>
>>> Signed-off-by: Stefan Herbrechtsmeier<stefan@herbrechtsmeier.net>
>>> ---
>>>   .../linux-firmware/linux-firmware_git.bb           |   10 +++++++---
>>>   1 files changed, 7 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
>>> index 52929fa..3675978 100644
>>> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
>>> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
>>> @@ -38,8 +38,8 @@ do_install() {
>>>       cp -r * ${D}/lib/firmware/
>>>
>>>       # Libertas sd8686
>>> -    install -m 0644 libertas/sd8686_v9.bin ${D}/lib/firmware/sd8686.bin
>>> -    install -m 0644 libertas/sd8686_v9_helper.bin ${D}/lib/firmware/sd8686_helper.bin
>>> +    ln -sf libertas/sd8686_v9.bin ${D}/lib/firmware/sd8686.bin
>>> +    ln -sf libertas/sd8686_v9_helper.bin ${D}/lib/firmware/sd8686_helper.bin
>>>
>>>       # Realtek rtl8192*
>>>       install -m 0644 LICENCE.rtlwifi_firmware.txt ${D}/lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt
>>> @@ -51,7 +51,11 @@ do_install() {
>>>   PACKAGES =+ "${PN}-sd8686 ${PN}-rtl8192cu linux-firmware-rtl8192ce linux-firmware-rtl8192su ${PN}-wl12xx"
>>>
>>>   LICENSE_${PN}-sd8686 = "Firmware:LICENSE.libertas"
>>> -FILES_${PN}-sd8686 = "/lib/firmware/sd8686* /lib/firmware/LICENCE.libertas"
>>> +FILES_${PN}-sd8686 = " \
>>> +  /lib/firmware/libertas/sd8686_v9* \
>>> +  /lib/firmware/sd8686* \
>>> +  /lib/firmware/LICENCE.libertas \
>>> +"
>>>
>>>   LICENSE_${PN}-rtl8192cu = "Firmware:LICENCE.rtlwifi_firmware"
>>>   FILES_${PN}-rtl8192cu = " \
>> Merged into OE-Core
> why? It's missing a PR bump. We're close to a release, can we please stop pushing broken commits, especially when a large part of the developers are travelling?
Should I send an additional patch for the PR bump?




      reply	other threads:[~2012-04-10 13:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-05 10:36 [PATCH] linux-firmware: keep version string in libertas firmware Stefan Herbrechtsmeier
2012-04-06  3:17 ` Saul Wold
2012-04-06 13:31   ` Koen Kooi
2012-04-10 13:18     ` Stefan Herbrechtsmeier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F843326.2@herbrechtsmeier.net \
    --to=stefan@herbrechtsmeier.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox