From: Darren Hart <dvhart@linux.intel.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] boot-directdisk: remove the default setting of SYSLINUXCFG and SYSLINUXMENU
Date: Tue, 10 Apr 2012 15:05:40 -0700 [thread overview]
Message-ID: <4F84AEB4.4040109@linux.intel.com> (raw)
In-Reply-To: <560645d66f6a67d7a23531a3002d19ab37db1d01.1334094326.git.sgw@linux.intel.com>
On 04/10/2012 02:49 PM, Saul Wold wrote:
> These two should get setup in {S} and installed into {HDDDIR}, by
> having them defined with {HDDDIR} they try to get created when the
> directory does not exist yet.
And they conflict with the syslinux.bbclass which now has appropriate
defaults. This is cruft left over from resurrecting directdisk.
>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
Acked-by: Darren Hart <dvhart@linux.intel.com>
> ---
> meta/classes/boot-directdisk.bbclass | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/meta/classes/boot-directdisk.bbclass b/meta/classes/boot-directdisk.bbclass
> index e9e1ba3..7d8f8ff 100644
> --- a/meta/classes/boot-directdisk.bbclass
> +++ b/meta/classes/boot-directdisk.bbclass
> @@ -40,9 +40,6 @@ AUTO_SYSLINUXCFG = "1"
> SYSLINUX_ROOT ?= "root=/dev/sda2"
> SYSLINUX_TIMEOUT ?= "10"
>
> -SYSLINUXCFG = "${HDDDIR}/syslinux.cfg"
> -SYSLINUXMENU = "${HDDDIR}/menu"
> -
> inherit syslinux
>
> build_boot_dd() {
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2012-04-10 22:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 21:49 [PATCH 0/2] A couple of fixes for Build Appliance Saul Wold
2012-04-10 21:49 ` [PATCH 1/2] boot-directdisk: remove the default setting of SYSLINUXCFG and SYSLINUXMENU Saul Wold
2012-04-10 22:05 ` Darren Hart [this message]
2012-04-10 21:49 ` [PATCH 2/2] task-self-hosted: Add vte and eglibc-gconv-ibm850 Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F84AEB4.4040109@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox