From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com ([147.11.146.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SKBxZ-0004f3-Id for openembedded-core@lists.openembedded.org; Tue, 17 Apr 2012 19:12:57 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail1.windriver.com (8.14.3/8.14.3) with ESMTP id q3HH3UjM015058 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Tue, 17 Apr 2012 10:03:30 -0700 (PDT) Received: from msp-dhcp23.wrs.com (172.25.34.23) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.1.255.0; Tue, 17 Apr 2012 10:03:29 -0700 Message-ID: <4F8DA261.2050605@windriver.com> Date: Tue, 17 Apr 2012 12:03:29 -0500 From: Mark Hatle Organization: Wind River Systems User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: References: <4da378412f0dceff4b3c3757a185ffa67997599c.1334616144.git.mark.hatle@windriver.com> In-Reply-To: <4da378412f0dceff4b3c3757a185ffa67997599c.1334616144.git.mark.hatle@windriver.com> Subject: FYI -- Re: [PATCH 16/17] lrzsz: sz, sx and sb were linked incorrectly X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2012 17:12:58 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Just wanted to highlight this patch. It should probably go into oe-core before the freeze, as the existing lrzsz package is completely broken. (None of the send functions are linked properly and will fail to work.) Since nobody has reported this, I do find it highly suspect this this component is even being used these days. --Mark On 4/16/12 6:16 PM, Mark Hatle wrote: > The sz, sx and sb links were created incorrectly to lrz, they should > point to lsz. > > Signed-off-by: Mark Hatle > --- > meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb > index 414f2f4..7f86157 100644 > --- a/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb > +++ b/meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb > @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \ > file://src/lrz.c;beginline=1;endline=10;md5=5276956373ff7d8758837f6399a1045f" > SECTION = "console/network" > DEPENDS = "" > -PR = "r3" > +PR = "r4" > > SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \ > file://autotools.patch \ > @@ -28,13 +28,19 @@ do_install() { > } > > pkg_postinst_${PN}() { > - for util in rz rx rb sz sx sb; do > + for util in rz rx rb; do > update-alternatives --install ${bindir}/$util $util lrz 100 > done > + for util in sz sx sb; do > + update-alternatives --install ${bindir}/$util $util lsz 100 > + done > } > > pkg_postrm_${PN}() { > - for util in rz rx rb sz sx sb; do > + for util in rz rx rb; do > update-alternatives --remove $util ${bindir}/lrz > done > + for util sz sx sb; do > + update-alternatives --remove $util ${bindir}/lsz > + done > }