From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] gdk-pixbuf: Add --with-x11 when building lsb image
Date: Sat, 28 Apr 2012 11:19:35 +0800 [thread overview]
Message-ID: <4F9B61C7.9050606@windriver.com> (raw)
In-Reply-To: <1335524304.20130.60.camel@ted>
On 2012年04月27日 18:58, Richard Purdie wrote:
> On Fri, 2012-04-27 at 16:39 +0800, Xiaofeng Yan wrote:
>> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>
>> LSB Test Suite complain "no library libgdk_pixbuf_xlib-2.0.so.0" \
>> because of having "--without-x11" for gdk-pixbuf_2.24.1.bb.
>> Use the linuxstdbase override and also make it
>> conditional on x11 being in DISTRO_FEATURES for passing lsb test
>>
>> [YOCTO #2284]
>>
>> Signed-off-by: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>> ---
>> meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb | 5 +++--
>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
>> index e31f717..3000c79 100644
>> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
>> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
>> @@ -19,7 +19,7 @@ SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${
>> SRC_URI[md5sum] = "72f39b34b20f68148c1609bd27415412"
>> SRC_URI[sha256sum] = "da7a3f00db360913716368e19e336402755cafa93769f3cfa28a969303e4bee1"
>>
>> -PR = "r0"
>> +PR = "r1"
>>
>> inherit autotools pkgconfig gettext
> Your patch will leave it enabled in the non-lsb case under many
> circumstances. How about something like:
>
> @@ -28,10 +28,13 @@ LIBV = "2.10.0"
> EXTRA_OECONF = "\
> --without-libtiff \
> --with-libpng \
> - --without-x11 \
> + ${X11DEPENDS} \
> --disable-introspection \
> "
>
> +X11DEPENDS = "--without-x11"
> +X11DEPENDS_linuxstdbase = "${@base_contains('DISTRO_FEATURES', 'x11', '--with-x11', '--without-x11', d)}"
> +
> FILES_${PN} = "${bindir}/gdk-pixbuf-query-loaders \
> ${libdir}/lib*.so.*"
>
>
> I'd also like to split the library into a separate package.
got it, thanks for your suggestion.
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2012-04-28 3:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 8:39 [PATCH 0/1] gdk-pixbuf: Add --with-x11 when building lsb image Xiaofeng Yan
2012-04-27 8:39 ` [PATCH 1/1] " Xiaofeng Yan
2012-04-27 10:58 ` Richard Purdie
2012-04-28 3:19 ` Xiaofeng Yan [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 5:50 [PATCH 0/1]:gdk-pixbuf: " Xiaofeng Yan
2012-04-24 5:50 ` [PATCH 1/1] gdk-pixbuf: " Xiaofeng Yan
2012-04-24 5:53 ` Koen Kooi
2012-04-24 6:12 ` Xiaofeng Yan
2012-04-24 6:29 ` Koen Kooi
2012-04-24 7:29 ` Richard Purdie
2012-04-24 8:59 ` Xiaofeng Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9B61C7.9050606@windriver.com \
--to=xiaofeng.yan@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox