Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] nfs-utils: don't try to unload nfsd module
Date: Thu, 03 May 2012 13:25:55 -0700	[thread overview]
Message-ID: <4FA2E9D3.3070702@linux.intel.com> (raw)
In-Reply-To: <1335815880-7346-1-git-send-email-obi@opendreambox.org>

On 04/30/2012 12:58 PM, Andreas Oberritter wrote:
> * When nfsserver get's stopped, "modprobe -r nfsd" may
>    hang indefinitely. As there's no need to unload the
>    module, just remove the call to modprobe.
>
> Signed-off-by: Andreas Oberritter<obi@opendreambox.org>
> ---
>   .../nfs-utils/nfs-utils/nfsserver                  |    8 --------
>   .../nfs-utils/nfs-utils_1.2.3.bb                   |    2 +-
>   2 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver b/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
> index 69c8718..e460e26 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils/nfsserver
> @@ -105,14 +105,6 @@ stop_nfsd(){
>   	}
>   	then
>   		echo done
> -		# This will remove, recursively, dependencies
> -		echo -n 'removing nfsd kernel module: '
> -		if modprobe -r nfsd
> -		then
> -			echo done
> -		else
> -			echo failed
> -		fi
>   	else
>   		echo failed
>   	fi
> diff --git a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> index d047940..eb18aaa 100644
> --- a/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> +++ b/meta/recipes-connectivity/nfs-utils/nfs-utils_1.2.3.bb
> @@ -12,7 +12,7 @@ DEPENDS = "libcap libnfsidmap libevent util-linux tcp-wrappers"
>   RDEPENDS_${PN} = "portmap"
>   RRECOMMENDS_${PN} = "kernel-module-nfsd"
>
> -PR = "r3"
> +PR = "r4"
>
>   SRC_URI = "${SOURCEFORGE_MIRROR}/nfs/nfs-utils-${PV}.tar.bz2 \
>              file://nfs-utils-1.0.6-uclibc.patch \

Merged into OE-Core

Thanks
	Sau!



      reply	other threads:[~2012-05-03 20:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30 19:58 [PATCH] nfs-utils: don't try to unload nfsd module Andreas Oberritter
2012-05-03 20:25 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA2E9D3.3070702@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox