From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/2] rootfs_rpm.bbclass: don't remove rpmlib when INC_RPM_IMAGE_GEN=1
Date: Wed, 9 May 2012 10:34:41 -0500 [thread overview]
Message-ID: <4FAA8E91.7050708@windriver.com> (raw)
In-Reply-To: <033DD718-AA9D-4F09-9E06-13C14DBBB7AC@dominion.thruhere.net>
On 5/9/12 10:24 AM, Koen Kooi wrote:
>
> Op 9 mei 2012, om 17:15 heeft Mark Hatle het volgende geschreven:
>
>> On 5/9/12 10:01 AM, Koen Kooi wrote:
>>>
>>> Op 9 mei 2012, om 16:52 heeft Mark Hatle het volgende geschreven:
>>>
>>>> On 5/9/12 3:50 AM, Koen Kooi wrote:
>>>>>
>>>>> Op 9 mei 2012, om 10:20 heeft Robert Yang het volgende geschreven:
>>>>>
>>>>>> Don't remove rpmlib when INC_RPM_IMAGE_GEN=1, otherwise the
>>>>>> list_installed_packages would get nothing in the second build.
>>>>>
>>>>> What happens when I do a build, enable INC_RPM_IMAGE_GEN and do another build?
>>>>
>>>> The intention is that only the packages that have been changed/upgraded will be installed. Instead of the whole image being generated from scratch each time.
>>>
>>> That's what INC_RPM_IMAGE_GEN does, yes. What I'm asking is how this patch addresses the sequence I outlined above.
>>
>> Explain what you mean by "build".
>>
>> Using the following:
>>
>> . ./oe-init-build-env build-test
>> <setup local.conf w/ rpm packaging and INC_RPM_IMAGE_GEN>
>> bitbake core-image-core
>> --- time passes, git pull pulls in changes ---
>> bitbake core-image-core
>>
>> The second "build", only the changed packages will be added to the image.
>>
>> You you are using different build directories, then it doesn't re-use anything. The purpose of this is incremental software development within a single build directory.
>
> You are still missing my point. The patch is broken if you change INC_RPM_IMAGE_GEN
I am absolutely missing your point.
I don't see what is wrong in the following, but I haven't tried it:
> - rm -rf ${IMAGE_ROOTFS}${rpmlibdir}
> - rm -rf ${IMAGE_ROOTFS}${opkglibdir}
> + # Don't remove the rpmlib when INC_RPM_IMAGE_GEN=1
> + if [ "${INC_RPM_IMAGE_GEN}" != "1" ]; then
> + rm -rf ${IMAGE_ROOTFS}${rpmlibdir}
> + rm -rf ${IMAGE_ROOTFS}${opkglibdir}
> + fi
If the INC_RPM_IMAGE_GEN is not set to '1'. (Specifically '1' as opposed to
just checking if it's set.) then it'll remove the existing image packaging database.
--Mark
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2012-05-09 15:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 8:20 [PATCH 0/2] Fix incremental rpm image generation Robert Yang
2012-05-09 8:20 ` [PATCH 1/2] package_rpm.bbclass: " Robert Yang
2012-05-09 8:20 ` [PATCH 2/2] rootfs_rpm.bbclass: don't remove rpmlib when INC_RPM_IMAGE_GEN=1 Robert Yang
2012-05-09 8:50 ` Koen Kooi
2012-05-09 14:52 ` Mark Hatle
2012-05-09 15:01 ` Koen Kooi
2012-05-09 15:15 ` Mark Hatle
2012-05-09 15:24 ` Koen Kooi
2012-05-09 15:34 ` Mark Hatle [this message]
2012-05-10 2:13 ` Robert Yang
2012-05-11 16:54 ` Saul Wold
2012-05-12 9:40 ` Robert Yang
2012-05-09 15:54 ` Marko Lindqvist
2012-05-09 16:04 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAA8E91.7050708@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox