From: Joshua Lock <josh@linux.intel.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [RFC PATCH 3/3] sstate.bbclass: ensure sstate files are easily shared
Date: Wed, 09 May 2012 18:01:35 -0700 [thread overview]
Message-ID: <4FAB136F.80800@linux.intel.com> (raw)
In-Reply-To: <4FAB0B6A.6010303@linux.intel.com>
On 09/05/12 17:27, Saul Wold wrote:
> On 05/09/2012 05:22 PM, Joshua Lock wrote:
>> In order to make sstate cache's more easily shared ensure any user of
>> the system has rwx permission by calling chown on sstate files after
>> they're created.
>>
>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>> ---
>> meta/classes/sstate.bbclass | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
>> index a8c98e5..6707ecf 100644
>> --- a/meta/classes/sstate.bbclass
>> +++ b/meta/classes/sstate.bbclass
>> @@ -454,6 +454,7 @@ sstate_create_package () {
>> else
>> tar -cz --file=$TFILE --files-from=/dev/null
>> fi
>> + chmod 0777 $TFILE
>> mv $TFILE ${SSTATE_PKG}
>>
>> cd ${WORKDIR}
> Why execute permission, and should it not be restricted to 664 for group
> level write access? Why would multiple users be writing to the same
> sstate file anyways once it's there it could be read-only since a change
> will trigger a new sstate file, not a re-write of the existing one.
For permissions I figured that whichever I went with someone would have
an alternative suggestion so I went with as indiscriminate as possible
- that's the main reason this is an RFC.
When I was reproducing the bug and had read-only siginfo file things
blew up, so I created them writeable, see [1].
Cheers,
Joshua
1. https://bugzilla.yoctoproject.org/show_bug.cgi?id=2041#c9
--
Joshua Lock
Yocto Project
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-05-10 1:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 0:22 [RFC PATCH 0/3] Shared state for all ! Joshua Lock
2012-05-10 0:22 ` [RFC PATCH 1/3] lib/bb/utils.py: add optional mode parameter to bb.utils.mkdirhier() Joshua Lock
2012-05-10 11:19 ` Richard Purdie
2012-05-10 0:22 ` [RFC PATCH 2/3] lib/bb/siggen.py: create permissive files and directories Joshua Lock
2012-05-10 11:22 ` Richard Purdie
2012-05-10 16:10 ` Joshua Lock
2012-05-10 0:22 ` [RFC PATCH 3/3] sstate.bbclass: ensure sstate files are easily shared Joshua Lock
2012-05-10 0:27 ` Saul Wold
2012-05-10 1:01 ` Joshua Lock [this message]
2012-05-10 0:50 ` [RFC PATCH 0/3] Shared state for all ! Chris Larson
2012-05-10 1:05 ` Joshua Lock
2012-05-10 2:15 ` Chris Larson
2012-05-10 2:32 ` Joshua Lock
2012-05-10 3:10 ` Joshua Lock
2012-05-10 3:14 ` Joshua Lock
2012-05-10 5:16 ` Khem Raj
2012-05-10 16:12 ` Joshua Lock
2012-05-10 16:31 ` Khem Raj
2012-05-10 7:25 ` Koen Kooi
2012-05-10 16:05 ` Joshua Lock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAB136F.80800@linux.intel.com \
--to=josh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=sgw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox