Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>,
	openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] libtool: fixed parallel build related race
Date: Thu, 24 May 2012 11:33:06 -0700	[thread overview]
Message-ID: <4FBE7EE2.3000909@linux.intel.com> (raw)
In-Reply-To: <1337536477-7047-1-git-send-email-enrico.scholz@sigma-chemnitz.de>

On 05/20/2012 10:54 AM, Enrico Scholz wrote:
> While building libtool, the libtool script itself will be regenerated
> because OE modifies a dependency[1]. With -jX, this operation (-->
> removal, creation of non-x file, 'chmod a+x') can happen at a time when
> the script is going to be executed.  This can cause errors like:
>
> | arm-linux-gnueabi-libtool: compile:  ccache arm-linux-gnueabi-gcc ...
> | ...
> | /bin/sh ./config.status libtool
> | ...
> | arm-linux-gnueabi-libtool: compile:  ccache arm-linux-gnueabi-gcc ...
> | /bin/sh: ./arm-linux-gnueabi-libtool: Permission denied
> | make[2]: *** [libltdl/libltdl_libltdl_la-lt__alloc.lo] Error 126
>
> I am not sure whether the custom do_compile_prepend() is still needed.
> For now only the issue above will be fixed by executing ./config.status
> yet again.
>
> [1] see 648290d5bf4d6ff50d3643bb7ad902dfc23aa702
>
> Signed-off-by: Enrico Scholz<enrico.scholz@sigma-chemnitz.de>
> ---
>   meta/recipes-devtools/libtool/libtool-2.4.2.inc |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/libtool/libtool-2.4.2.inc b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> index 084062a..c1ef7c4 100644
> --- a/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> +++ b/meta/recipes-devtools/libtool/libtool-2.4.2.inc
> @@ -8,7 +8,7 @@ LICENSE = "GPLv2&  LGPLv2.1"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
>       file://libltdl/COPYING.LIB;md5=e3eda01d9815f8d24aae2dbd89b68b06"
>
> -INC_PR = "r2"
> +INC_PR = "r3"
>
>   SRC_URI = "${GNU_MIRROR}/libtool/libtool-${PV}.tar.gz \
>              file://trailingslash.patch \
> @@ -27,6 +27,7 @@ do_compile_prepend () {
>   	# Sometimes this file doesn't get rebuilt, force the issue
>   	rm -f ${S}/libltdl/config/ltmain.sh
>   	make libltdl/config/ltmain.sh
> +	./config.status
>   }
>
>   inherit autotools

Merged into OE-Core

Thanks
	Sau!



      reply	other threads:[~2012-05-24 18:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-20 17:54 [PATCH] libtool: fixed parallel build related race Enrico Scholz
2012-05-24 18:33 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBE7EE2.3000909@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=enrico.scholz@sigma-chemnitz.de \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox