From: Darren Hart <darren.hart@intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: "Ashfield, Bruce" <Bruce.Ashfield@windriver.com>,
openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] cmd1.bbclass: Ensure ncurses is built and used for menuconfig tasks
Date: Thu, 31 May 2012 07:46:35 -0700 [thread overview]
Message-ID: <4FC7844B.3030608@intel.com> (raw)
In-Reply-To: <1338470972.20169.234.camel@ted>
On 05/31/2012 06:29 AM, Richard Purdie wrote:
> Currently, the task just exits if something goes wrong. This adds the
> ncurses-native dependency. It also adds a small delay before closing the
> window so any messages displayed there can be seen.
>
> Trying to get the kernel build system to correctly find and link with
> our copy of ncurses is some kind of nightmare. I ended up having to add
> it to HOST_LOADLIBES globally for this task which is rather nasty but I
> couldn't find any other way.
>
> [YOCTO #2513]
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index d429188..bd25311 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -9,9 +9,15 @@ addtask configure after do_unpack do_patch before do_compile
>
> inherit terminal
>
> +OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOSTLDFLAGS HOST_LOADLIBES"
> +HOST_EXTRACFLAGS = "${BUILD_CFLAGS} ${BUILD_LDFLAGS}"
> +HOSTLDFLAGS = "${BUILD_LDFLAGS}"
> +HOST_LOADLIBES = "-lncurses"
> +
> python do_menuconfig() {
> - oe_terminal("make menuconfig", '${PN} Configuration', d)
> + oe_terminal("${SHELL} -c \"make menuconfig; echo 'Pausing for 5 seconds'; sleep 5\"", '${PN} Configuration', d)
Perhaps only sleeping if menuconfig returns non-zero? This would avoid
the unnecessary lag after a successful menuconfig session.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
next prev parent reply other threads:[~2012-05-31 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 13:29 [PATCH] cmd1.bbclass: Ensure ncurses is built and used for menuconfig tasks Richard Purdie
2012-05-31 14:46 ` Darren Hart [this message]
2012-05-31 15:02 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC7844B.3030608@intel.com \
--to=darren.hart@intel.com \
--cc=Bruce.Ashfield@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox