From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/3] lsbinitscripts: Remove original /etc/init.d/functions when building an lsb image
Date: Mon, 18 Jun 2012 11:08:26 +0800 [thread overview]
Message-ID: <4FDE9BAA.2000602@windriver.com> (raw)
In-Reply-To: <4FDE9912.60406@windriver.com>
On 2012年06月18日 10:57, Xiaofeng Yan wrote:
> On 2012年06月15日 22:59, Richard Purdie wrote:
>> On Fri, 2012-06-15 at 17:30 +0800, xiaofeng.yan@windriver.com wrote:
>>> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>>
>>> The linking will fail when an original functions exist. So remove the
>>> original functions when building an lsb image and make functions
>>> linking to
>>> functions.lsbinitscripts successfully.
>>>
>>> [YOCTO #2133]
>>>
>>> Signed-off-by: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>> ---
>>> meta/recipes-extended/lsb/lsbinitscripts_9.03.bb | 8 +++++++-
>>> 1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-extended/lsb/lsbinitscripts_9.03.bb
>>> b/meta/recipes-extended/lsb/lsbinitscripts_9.03.bb
>>> index dd92a92..73bea2f 100644
>>> --- a/meta/recipes-extended/lsb/lsbinitscripts_9.03.bb
>>> +++ b/meta/recipes-extended/lsb/lsbinitscripts_9.03.bb
>>> @@ -2,7 +2,7 @@ DESCRIPTION = "SysV init scripts which only is used
>>> in an LSB image"
>>> SECTION = "base"
>>> LICENSE = "GPLv2"
>>> DEPENDS = "popt"
>>> -PR = "r0"
>>> +PR = "r1"
>>>
>>> LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=ebf4e8b49780ab187d51bd26aaa022c6"
>>>
>>> @@ -25,3 +25,9 @@ do_install(){
>>> install -d ${D}/etc/init.d/
>>> install -m 0755 ${S}/rc.d/init.d/functions
>>> ${D}/etc/init.d/functions
>>> }
>>> +
>>> +pkg_postinst_${PN} () {
>>> + if [ -f "/etc/init.d/functions" ]; then
>>> + rm -f /etc/init.d/functions
>>> + fi
>>> +}
>> This looks highly suspicious to me. Shouldn't the other provider of this
>> be put under control for update-alternatives too or something?
> Thanks for your comments.
> the other provider of this is from initscripts_1.0.bb, installing all
> of init-scripts in the stage of installing without using
> update-alternatives. So the functions is a file instead of linking
> mode. An error appear when lsbinicscritps replace initscripts if not
> removing file functions. So I remove the original functions for making
> the latter linking successfully. What is the purpose is for avoiding
> to modify the other non-lsb bb files. The changes of this will be only
> in lsb image.
Can we add the removing function if not a linking when using
update-alternatives ?
> Thanks
> Yan
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2012-06-18 3:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 9:30 [PATCH 0/3] lsbinitscripts: support multilib, link function and add the header for patch xiaofeng.yan
2012-06-15 9:30 ` [PATCH 1/3] multilib.conf: Add the support of multilib for lsbinitscripts xiaofeng.yan
2012-06-15 9:30 ` [PATCH 2/3] lsbinitscripts: Remove original /etc/init.d/functions when building an lsb image xiaofeng.yan
2012-06-15 14:59 ` Richard Purdie
2012-06-18 2:57 ` Xiaofeng Yan
2012-06-18 3:08 ` Xiaofeng Yan [this message]
2012-06-21 15:38 ` Richard Purdie
2012-06-15 9:30 ` [PATCH 3/3] lsbinitscripts: Add the header for functions.patch xiaofeng.yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDE9BAA.2000602@windriver.com \
--to=xiaofeng.yan@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox