From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gconf.bbclass: don't register schemas in the install stage
Date: Thu, 28 Jun 2012 10:14:53 -0700 [thread overview]
Message-ID: <4FEC910D.9020305@linux.intel.com> (raw)
In-Reply-To: <1340705423-18430-1-git-send-email-ross.burton@intel.com>
On 06/26/2012 03:10 AM, Ross Burton wrote:
> Previously this was installing schemas in the sysroot, which is wrong for native
> packages as nothing should touch the sysroot directly, and even more wrong for
> non-native packages as the sysroot is irrelevant.
>
> So, export the environment variable that stops the registration happening at
> install time. The postinst script will handle the non-native case, and for the
> sysroot I've opened #2648. This isn't a massive problem as nothing to my
> knowledge actually installs schemas to the sysroot.
>
> [YOCTO #2245]
>
> Signed-off-by: Ross Burton<ross.burton@intel.com>
> ---
> meta/classes/gconf.bbclass | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/gconf.bbclass b/meta/classes/gconf.bbclass
> index a966c26..fb9f701 100644
> --- a/meta/classes/gconf.bbclass
> +++ b/meta/classes/gconf.bbclass
> @@ -1,10 +1,18 @@
> DEPENDS += "gconf gconf-native"
>
> -# This is referenced by the gconf m4 macros and would default to the value hardcoded
> -# into gconf at compile time otherwise
> +# These are for when gconftool is used natively and the prefix isn't necessarily
> +# the sysroot. TODO: replicate the postinst logic for -native packages going
> +# into sysroot as they won't be running their own install-time schema
> +# registration (disabled below) nor the postinst script (as they don't happen).
> export GCONF_SCHEMA_INSTALL_SOURCE = "xml:merged:${STAGING_DIR_NATIVE}${sysconfdir}/gconf/gconf.xml.defaults"
> export GCONF_BACKEND_DIR = "${STAGING_LIBDIR_NATIVE}/GConf/2"
>
> +# Disable install-time schema registration as we're a packaging system so this
> +# happens in the postinst script, not at install time. Set both the configure
> +# script option and the traditional envionment variable just to make sure.
> +EXTRA_OECONF += "--disable-schemas-install"
> +export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL = "1"
> +
> gconf_postinst() {
> if [ "x$D" != "x" ]; then
> exit 1
Merged into OE-Core - Still needs to be merged to 1.2.1
Thanks
Sau!
prev parent reply other threads:[~2012-06-28 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-26 10:10 [PATCH] gconf.bbclass: don't register schemas in the install stage Ross Burton
2012-06-26 21:02 ` Colin Walters
2012-06-27 6:01 ` Ross Burton
2012-06-28 22:10 ` Colin Walters
2012-06-28 17:14 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEC910D.9020305@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox