Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
	openembedded-core@lists.openembedded.org,
	Poky <poky@yoctoproject.org>
Subject: Re: [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images
Date: Mon, 02 Jul 2012 06:33:42 -0700	[thread overview]
Message-ID: <4FF1A336.1090401@linux.intel.com> (raw)
In-Reply-To: <444946729b775e1cb91ebb599f9aca4458bdf176.1341025161.git.dvhart@linux.intel.com>

Paul, do you think this patch is necessary or is this just covering up
for Bug 2595?

--
Darren

On 06/29/2012 09:25 PM, Darren Hart wrote:
> While sdk images already have dev-pkgs included, the kernel-dev package
> is special and does not get installed. Add kernel-dev explicitly to the
> *sdk image recipes.
> 
> Note: We have to be careful with "IMAGE_INSTALL +=" as it must appear
> after "inherit core-image" which makes an "IMAGE_INSTALL ?=" assignment.
> 
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> CC: Jessica Zhang <jessica.zhang@intel.com>
> CC: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-extended/images/core-image-lsb-sdk.bb |    1 +
>  meta/recipes-rt/images/core-image-rt-sdk.bb        |    2 +-
>  meta/recipes-sato/images/core-image-sato-sdk.bb    |    3 +++
>  3 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/images/core-image-lsb-sdk.bb b/meta/recipes-extended/images/core-image-lsb-sdk.bb
> index 32a5077..047d66b 100644
> --- a/meta/recipes-extended/images/core-image-lsb-sdk.bb
> +++ b/meta/recipes-extended/images/core-image-lsb-sdk.bb
> @@ -10,6 +10,7 @@ IMAGE_INSTALL = "\
>      ${CORE_IMAGE_BASE_INSTALL} \
>      task-core-basic \
>      task-core-lsb \
> +    kernel-dev \
>      "
>  
>  inherit core-image
> diff --git a/meta/recipes-rt/images/core-image-rt-sdk.bb b/meta/recipes-rt/images/core-image-rt-sdk.bb
> index 6ec2d00..29512e3 100644
> --- a/meta/recipes-rt/images/core-image-rt-sdk.bb
> +++ b/meta/recipes-rt/images/core-image-rt-sdk.bb
> @@ -11,6 +11,6 @@ DEPENDS = "linux-yocto-rt"
>  IMAGE_FEATURES += "dev-pkgs tools-sdk"
>  EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
>  
> -IMAGE_INSTALL += "rt-tests"
> +IMAGE_INSTALL += "rt-tests kernel-dev"
>  
>  LICENSE = "MIT"
> diff --git a/meta/recipes-sato/images/core-image-sato-sdk.bb b/meta/recipes-sato/images/core-image-sato-sdk.bb
> index eed1698..75ed64f 100644
> --- a/meta/recipes-sato/images/core-image-sato-sdk.bb
> +++ b/meta/recipes-sato/images/core-image-sato-sdk.bb
> @@ -11,3 +11,6 @@ EXTRA_IMAGE_FEATURES += "tools-debug tools-profile tools-testapps debug-tweaks"
>  LICENSE = "MIT"
>  
>  inherit core-image
> +
> +IMAGE_INSTALL += "kernel-dev"
> +
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel





      reply	other threads:[~2012-07-02 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-30  4:25 [PATCH 0/3 V3b] Enable building modules on target Darren Hart
2012-06-30  4:25 ` [PATCH 1/3] kernel: Add kernel headers to kernel-dev package Darren Hart
2012-07-01  3:51   ` Bruce Ashfield
2012-07-02 13:32     ` Darren Hart
2012-06-30  4:25 ` [PATCH 2/3] linux-yocto-custom: Remove linux-tools Darren Hart
2012-06-30  4:25 ` [PATCH 3/3] core-image*sdk: Add kernel-dev to sdk images Darren Hart
2012-07-02 13:33   ` Darren Hart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF1A336.1090401@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    --cc=poky@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox