From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from 75-148-42-21-colorado.hfc.comcastbusiness.net ([75.148.42.21] helo=judge.camp.se-eng.com) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SliLc-0003ZO-LH for openembedded-core@lists.openembedded.org; Mon, 02 Jul 2012 17:15:33 +0200 Received: from localhost (localhost [127.0.0.1]) by judge.camp.se-eng.com (Postfix) with ESMTP id D96DD13935B; Mon, 2 Jul 2012 09:04:27 -0600 (MDT) X-Virus-Scanned: amavisd-new at camp.se-eng.com Received: from judge.camp.se-eng.com ([127.0.0.1]) by localhost (judge.camp.se-eng.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kYmqJSh0Y4Wj; Mon, 2 Jul 2012 09:04:16 -0600 (MDT) Received: from [172.20.202.96] (beast.camp.se-eng.com [172.20.202.96]) by judge.camp.se-eng.com (Postfix) with ESMTPSA id 98CE713935A; Mon, 2 Jul 2012 09:04:15 -0600 (MDT) Message-ID: <4FF1B8BD.2000104@se-eng.com> Date: Mon, 02 Jul 2012 09:05:33 -0600 From: Raymond Danks User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120129 Thunderbird/10.0 MIME-Version: 1.0 To: Saul Wold References: <1340984497-32423-2-git-send-email-ray.danks@se-eng.com> <1341001154-10071-1-git-send-email-ray.danks@se-eng.com> <4FF12208.3000702@linux.intel.com> In-Reply-To: <4FF12208.3000702@linux.intel.com> Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/2 v3] image_types: Add elf image type X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: ray.danks@se-eng.com, Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 15:15:33 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 07/01/2012 10:22 PM, Saul Wold wrote: > On 06/29/2012 01:19 PM, Raymond Danks wrote: >> On x86, an ELF image file may be stored as a coreboot payload. >> The image file is constructed, using the mkelfimage utility, >> from a kernel and an initrd. >> >> Signed-off-by: Raymond Danks >> --- >> This was originally submitted to the openembedded project: >> http://patches.openembedded.org/patch/7689/ >> >> v3: >> Include DEPLOY_DIR_IMAGE and KERNEL_IMAGETYPE for location of >> ELF_KERNEL >> >> meta/classes/image_types.bbclass | 18 +++++++++++++++++- >> 1 files changed, 17 insertions(+), 1 deletions(-) >> >> diff --git a/meta/classes/image_types.bbclass >> b/meta/classes/image_types.bbclass >> index 55f122e..64fa14a 100644 >> --- a/meta/classes/image_types.bbclass >> +++ b/meta/classes/image_types.bbclass >> @@ -7,6 +7,12 @@ def get_imagecmds(d): >> ctypes = d.getVar('COMPRESSIONTYPES', True).split() >> cimages = {} >> >> + if "elf" in alltypes: >> + alltypes.remove("elf") >> + if "cpio.gz" not in alltypes: >> + alltypes.append("cpio.gz") >> + alltypes.append("elf") >> + >> # Filter out all the compressed images from types >> for type in alltypes: >> basetype = None >> @@ -173,6 +179,14 @@ IMAGE_CMD_cpio () { >> cd ${IMAGE_ROOTFS}&& (find . | cpio -o -H >> newc>${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio) >> } >> >> +ELF_KERNEL ?= ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE} > > I guess this was not tested very well, as this failed right out of the > gate. Thanks for giving this a shot Sau. Could you be more specific regarding the failure you are seeing? > > Please let me know what kind of testing you have done. This was tested rather exhaustively on an x86_64->x86_64 configuration prior to the latest changes to the above line. I have only tested this using the bzImage kernel type. I did feel that I had tested the above line as well, but it's possible I had something cached somewhere. I'll kick off a clean build and see if anything surfaces. > > Thanks > Sau! >> +ELF_APPEND ?= "ramdisk_size=32768 root=/dev/ram0 rw console=" >> + >> +IMAGE_CMD_elf () { >> + test -f ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.elf&& rm -f >> ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.elf >> + mkelfImage --kernel=${ELF_KERNEL} >> --initrd=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio.gz >> --output=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.elf >> --append='${ELF_APPEND}' ${EXTRA_IMAGECMD} >> +} >> + >> UBI_VOLNAME ?= "${MACHINE}-rootfs" >> >> IMAGE_CMD_ubi () { >> @@ -199,6 +213,7 @@ EXTRA_IMAGECMD_ext2 ?= "-i 8192" >> EXTRA_IMAGECMD_ext3 ?= "-i 8192" >> EXTRA_IMAGECMD_ext4 ?= "-i 8192" >> EXTRA_IMAGECMD_btrfs ?= "" >> +EXTRA_IMAGECMD_elf ?= "" >> >> IMAGE_DEPENDS = "" >> IMAGE_DEPENDS_jffs2 = "mtd-utils-native" >> @@ -210,11 +225,12 @@ IMAGE_DEPENDS_ext4 = "genext2fs-native >> e2fsprogs-native" >> IMAGE_DEPENDS_btrfs = "btrfs-tools-native" >> IMAGE_DEPENDS_squashfs = "squashfs-tools-native" >> IMAGE_DEPENDS_squashfs-lzma = "squashfs-lzma-tools-native" >> +IMAGE_DEPENDS_elf = "virtual/kernel mkelfimage-native" >> IMAGE_DEPENDS_ubi = "mtd-utils-native" >> IMAGE_DEPENDS_ubifs = "mtd-utils-native" >> >> # This variable is available to request which values are suitable >> for IMAGE_FSTYPES >> -IMAGE_TYPES = "jffs2 sum.jffs2 cramfs ext2 ext2.gz ext2.bz2 ext3 >> ext3.gz ext2.lzma btrfs live squashfs squashfs-lzma ubi tar tar.gz >> tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma vmdk" >> +IMAGE_TYPES = "jffs2 sum.jffs2 cramfs ext2 ext2.gz ext2.bz2 ext3 >> ext3.gz ext2.lzma btrfs live squashfs squashfs-lzma ubi tar tar.gz >> tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma vmdk elf" >> >> COMPRESSIONTYPES = "gz bz2 lzma xz" >> COMPRESS_CMD_lzma = "lzma -k -f -7 ${IMAGE_NAME}.rootfs.${type}"