From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Slk1d-000526-PF for openembedded-core@lists.openembedded.org; Mon, 02 Jul 2012 19:03:02 +0200 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 02 Jul 2012 09:51:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,351,1309762800"; d="scan'208";a="165839532" Received: from unknown (HELO [10.255.12.182]) ([10.255.12.182]) by orsmga002.jf.intel.com with ESMTP; 02 Jul 2012 09:51:41 -0700 Message-ID: <4FF1D19D.3080906@linux.intel.com> Date: Mon, 02 Jul 2012 09:51:41 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: ray.danks@se-eng.com References: <1340984497-32423-2-git-send-email-ray.danks@se-eng.com> <1341001154-10071-1-git-send-email-ray.danks@se-eng.com> <4FF12208.3000702@linux.intel.com> <4FF1B8BD.2000104@se-eng.com> In-Reply-To: <4FF1B8BD.2000104@se-eng.com> Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/2 v3] image_types: Add elf image type X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2012 17:03:02 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 07/02/2012 08:05 AM, Raymond Danks wrote: > On 07/01/2012 10:22 PM, Saul Wold wrote: >> On 06/29/2012 01:19 PM, Raymond Danks wrote: >>> On x86, an ELF image file may be stored as a coreboot payload. >>> The image file is constructed, using the mkelfimage utility, >>> from a kernel and an initrd. >>> >>> Signed-off-by: Raymond Danks >>> --- >>> This was originally submitted to the openembedded project: >>> http://patches.openembedded.org/patch/7689/ >>> >>> v3: >>> Include DEPLOY_DIR_IMAGE and KERNEL_IMAGETYPE for location of ELF_KERNEL >>> >>> meta/classes/image_types.bbclass | 18 +++++++++++++++++- >>> 1 files changed, 17 insertions(+), 1 deletions(-) >>> >>> diff --git a/meta/classes/image_types.bbclass >>> b/meta/classes/image_types.bbclass >>> index 55f122e..64fa14a 100644 >>> --- a/meta/classes/image_types.bbclass >>> +++ b/meta/classes/image_types.bbclass >>> @@ -7,6 +7,12 @@ def get_imagecmds(d): >>> ctypes = d.getVar('COMPRESSIONTYPES', True).split() >>> cimages = {} >>> >>> + if "elf" in alltypes: >>> + alltypes.remove("elf") >>> + if "cpio.gz" not in alltypes: >>> + alltypes.append("cpio.gz") >>> + alltypes.append("elf") >>> + >>> # Filter out all the compressed images from types >>> for type in alltypes: >>> basetype = None >>> @@ -173,6 +179,14 @@ IMAGE_CMD_cpio () { >>> cd ${IMAGE_ROOTFS}&& (find . | cpio -o -H >>> newc>${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio) >>> } >>> >>> +ELF_KERNEL ?= ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE} >> >> I guess this was not tested very well, as this failed right out of the >> gate. > Thanks for giving this a shot Sau. Could you be more specific regarding > the failure you are seeing? Sorry, It was Sunday evening and I was a little grumpy at the failure occuring after all the version. ERROR: ParseError at /intel/poky/distro/meta/classes/image_types.bbclass:182: unparsed line: 'ELF_KERNEL ?= ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}' My guess is because you forgot the quotes on that line, now why I hit it instantly and you did not see it I am not sure. bitbake world and it will fail >> >> Please let me know what kind of testing you have done. > This was tested rather exhaustively on an x86_64->x86_64 configuration > prior to the latest changes to the above line. I have only tested this > using the bzImage kernel type. I did feel that I had tested the above > line as well, but it's possible I had something cached somewhere. I'll > kick off a clean build and see if anything surfaces. > >> >> Thanks >> Sau! >>> +ELF_APPEND ?= "ramdisk_size=32768 root=/dev/ram0 rw console=" >>> + >>> +IMAGE_CMD_elf () { >>> + test -f ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.elf&& rm -f >>> ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.elf >>> + mkelfImage --kernel=${ELF_KERNEL} >>> --initrd=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio.gz >>> --output=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.elf >>> --append='${ELF_APPEND}' ${EXTRA_IMAGECMD} >>> +} >>> + >>> UBI_VOLNAME ?= "${MACHINE}-rootfs" >>> >>> IMAGE_CMD_ubi () { >>> @@ -199,6 +213,7 @@ EXTRA_IMAGECMD_ext2 ?= "-i 8192" >>> EXTRA_IMAGECMD_ext3 ?= "-i 8192" >>> EXTRA_IMAGECMD_ext4 ?= "-i 8192" >>> EXTRA_IMAGECMD_btrfs ?= "" >>> +EXTRA_IMAGECMD_elf ?= "" >>> >>> IMAGE_DEPENDS = "" >>> IMAGE_DEPENDS_jffs2 = "mtd-utils-native" >>> @@ -210,11 +225,12 @@ IMAGE_DEPENDS_ext4 = "genext2fs-native >>> e2fsprogs-native" >>> IMAGE_DEPENDS_btrfs = "btrfs-tools-native" >>> IMAGE_DEPENDS_squashfs = "squashfs-tools-native" >>> IMAGE_DEPENDS_squashfs-lzma = "squashfs-lzma-tools-native" >>> +IMAGE_DEPENDS_elf = "virtual/kernel mkelfimage-native" >>> IMAGE_DEPENDS_ubi = "mtd-utils-native" >>> IMAGE_DEPENDS_ubifs = "mtd-utils-native" >>> >>> # This variable is available to request which values are suitable for >>> IMAGE_FSTYPES >>> -IMAGE_TYPES = "jffs2 sum.jffs2 cramfs ext2 ext2.gz ext2.bz2 ext3 >>> ext3.gz ext2.lzma btrfs live squashfs squashfs-lzma ubi tar tar.gz >>> tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma vmdk" >>> +IMAGE_TYPES = "jffs2 sum.jffs2 cramfs ext2 ext2.gz ext2.bz2 ext3 >>> ext3.gz ext2.lzma btrfs live squashfs squashfs-lzma ubi tar tar.gz >>> tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma vmdk elf" >>> >>> COMPRESSIONTYPES = "gz bz2 lzma xz" >>> COMPRESS_CMD_lzma = "lzma -k -f -7 ${IMAGE_NAME}.rootfs.${type}" > > >