From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] oprofile: Change /root to /home/root
Date: Mon, 2 Jul 2012 15:31:53 -0500 [thread overview]
Message-ID: <4FF20539.9030504@windriver.com> (raw)
In-Reply-To: <1341259602.2886.27.camel@x121e.pbcl.net>
On 7/2/12 3:06 PM, Phil Blundell wrote:
> On Mon, 2012-07-02 at 14:25 -0500, Mark Hatle wrote:
>> +diff -ur oprofile-0.9.7.orig/utils/opcontrol oprofile-0.9.7/utils/opcontrol
>> +--- oprofile-0.9.7.orig/utils/opcontrol 2011-07-20 14:36:48.000000000 -0500
>> ++++ oprofile-0.9.7/utils/opcontrol 2012-07-02 13:55:06.232872688 -0500
>> +@@ -384,7 +384,7 @@
>> + OPROFILED="$OPDIR/oprofiled"
>> +
>> + # location for daemon setup information
>> +- SETUP_DIR="/root/.oprofile"
>> ++ SETUP_DIR="/home/root/.oprofile"
>> + SETUP_FILE="$SETUP_DIR/daemonrc"
>> + SEC_SETUP_FILE="$SETUP_DIR/daemonrc_new"
>> +
>
> Why is it putting "daemon setup information" in /root in the first
> place? Surely that should go in /etc or some such place.
>
> Also, the choice of where root's home directory goes is a distro
> decision and, in the general case, it is not correct to say that "OE
> uses /home/root". Changing the hardcoded value from one thing to
> another is probably not that much of an improvement overall.
systemd (meta-oe), base-passwd, base-files (profile settings), xserver-
nodm-init-2.0/xserver-nodm -- they all have patches that change hard coded /root
to /home/root.
I don't honestly care which we used, but /home/root has been used as -the- root
directory on OE since as far back as 2004 from what I can tell.
As for the files, these are files used by the system to setup and store the
data. oprofile does this to the root home directory. I don't know or
understand why, other then I have a bug in my pile that says oprofile is
currently broken, as there is no /root directory.
--Mark
> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2012-07-02 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 19:25 [PATCH 0/1] Update oprofile to know about OE root home directory Mark Hatle
2012-07-02 19:25 ` [PATCH 1/1] oprofile: Change /root to /home/root Mark Hatle
2012-07-02 20:06 ` Phil Blundell
2012-07-02 20:31 ` Mark Hatle [this message]
2012-07-02 23:44 ` Khem Raj
2012-07-03 15:28 ` Philip Balister
2012-07-03 16:30 ` Mark Hatle
2012-07-03 16:45 ` Saul Wold
2012-07-03 16:55 ` Mark Hatle
2012-07-05 17:44 ` [PATCH 0/1] Update oprofile to know about OE root home directory Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF20539.9030504@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox