From: Saul Wold <sgw@linux.intel.com>
To: "Dennis.Yxun" <dennis.yxun@gmail.com>
Cc: floppym@gentoo.org,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace
Date: Mon, 02 Jul 2012 16:46:31 -0700 [thread overview]
Message-ID: <4FF232D7.70906@linux.intel.com> (raw)
In-Reply-To: <CAF1ZMEfVGmrhzMHwKErPo8x1wZCy_ZeVAGS4qDctpQ=d_jsAkg@mail.gmail.com>
On 07/02/2012 03:24 PM, Dennis.Yxun wrote:
> hi saul:
> please see my comment as following
>
I do not understand what you are getting at here?
You PATCH file openjade-1.3.2/msggen.pl.patch is what is missing the
Upsteam-Status: and SOB (Signed-off-by), the commit message what you
have for SOB is Ok, the commit message itself should not have the
Upstream-Status: tag, it belongs in the .patch file header.
Sau!
> dennis
>
> At 2012-6-29 AM1:27，"Saul Wold" &
>
> On 06/27/2012 09:56 PM, dennis lan wrote:
>
> From: Dennis Lan<dennis.yxun@gmail.com
> <mailto:dennis.yxun@gmail.com>>
>
> Using Gentoo Linux as the build host, it fails without this patch
> Use Getopt::Std in place of getopts.pl <http://getopts.pl>.
>
> https://bugs.gentoo.org/show___bug.cgi?id=420083
> <https://bugs.gentoo.org/show_bug.cgi?id=420083>
>
> which following error:
> /usr/bin/perl -w ./../msggen.pl <http://msggen.pl> -l
> jstyleModule InterpreterMessages.msg
> /usr/bin/perl -w ./../msggen.pl <http://msggen.pl> -l
> jstyleModule DssslAppMessages.msg
> Undefined subroutine&main::Getopts called at ./../msggen.pl
> <http://msggen.pl> line 22.
> make[2]: *** [InterpreterMessages.h] Error 2
> make[2]: *** Waiting for unfinished jobs....
> Undefined subroutine&main::Getopts called at ./../msggen.pl
> <http://msggen.pl> line 22.
> make[2]: *** [DssslAppMessages.h] Error 2
>
> Upstream-Status: Submitted
> [openjade-devel@lists.__sourceforge.net
> <mailto:openjade-devel@lists.sourceforge.net>]
>
> This needs to be in the patch file itself, we can track the patches
> better that way.
>
> Signed-off-by: Dennis Lan<dennis.yxun@gmail.com
> <mailto:dennis.yxun@gmail.com>>
> ---
> .../openjade/openjade-1.3.2/__msggen.pl.patch | 32
> ++++++++++++++++++++
> .../openjade/openjade-native___1.3.2.bb
> <http://openjade-native_1.3.2.bb> | 1 +
> 2 files changed, 33 insertions(+), 0 deletions(-)
> create mode 100644
> meta/recipes-devtools/__openjade/openjade-1.3.2/__msggen.pl.patch
>
> diff --git
> a/meta/recipes-devtools/__openjade/openjade-1.3.2/__msggen.pl.patch
> b/meta/recipes-devtools/__openjade/openjade-1.3.2/__msggen.pl.patch
> new file mode 100644
> index 0000000..1afe68b
> --- /dev/null
> +++
> b/meta/recipes-devtools/__openjade/openjade-1.3.2/__msggen.pl.patch
>
>
> Please add comment Upstream-Status and SOB to the patch itself.
>
> Thanks
> Sau!
>
> @@ -0,0 +1,32 @@
> +Use Getopt::Std in place of getopts.pl <http://getopts.pl>.
> +https://bugs.gentoo.org/show___bug.cgi?id=420083
> <https://bugs.gentoo.org/show_bug.cgi?id=420083>
> +
> +--- a/msggen.pl <http://msggen.pl>
> ++++ b/msggen.pl <http://msggen.pl>
> +@@ -4,6 +4,7 @@
> + # See the file COPYING for copying permission.
> +
> + use POSIX;
> ++use Getopt::Std;
> +
> + # Package and version.
> + $package = 'openjade';
> +@@ -18,8 +19,7 @@
> + undef $opt_l;
> + undef $opt_p;
> + undef $opt_t;
> +-do 'getopts.pl <http://getopts.pl>';
> +-&Getopts('l:p:t:');
> ++getopts('l:p:t:');
> + $module = $opt_l;
> + $pot_file = $opt_p;
> +
> +@@ -72,7 +72,7 @@
> + else {
> + $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid first
> field");;
> + $type[$num] = substr($field[0], 0, 1);
> +- $argc = int(substr($field[0], 1, 1));
> ++ $argc = substr($field[0], 1, 1);
> + }
> + $nargs[$num] = $argc;
> + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ ||&error("invalid
> tag");
> diff --git
> a/meta/recipes-devtools/__openjade/openjade-native_1.3.__2.bb
> <http://openjade-native_1.3.2.bb>
> b/meta/recipes-devtools/__openjade/openjade-native_1.3.__2.bb
> <http://openjade-native_1.3.2.bb>
> index 5b29c1f..efd1e11 100644
> ---
> a/meta/recipes-devtools/__openjade/openjade-native_1.3.__2.bb
> <http://openjade-native_1.3.2.bb>
> +++
> b/meta/recipes-devtools/__openjade/openjade-native_1.3.__2.bb
> <http://openjade-native_1.3.2.bb>
> @@ -14,6 +14,7 @@ RDEPENDS_${PN} = "sgml-common-native"
>
> SRC_URI =
> "${SOURCEFORGE_MIRROR}/__openjade/openjade-${PV}.tar.gz \
> file://makefile.patch \
> + file://msggen.pl.patch \
> file://reautoconf.patch \
> file://user-declared-default-__constructor.patch"
>
next prev parent reply other threads:[~2012-07-02 23:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-28 4:56 [PATCH v2] openjade-native: fix undefined Getopts error, use std namespace dennis lan
2012-06-28 6:02 ` Dennis.Yxun
2012-06-28 17:27 ` Saul Wold
2012-07-02 22:24 ` Dennis.Yxun
2012-07-02 23:46 ` Saul Wold [this message]
2012-07-03 0:29 ` Dennis.Yxun
2012-07-03 0:46 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF232D7.70906@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=dennis.yxun@gmail.com \
--cc=floppym@gentoo.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox