From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com ([192.55.52.93]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Sm7Ah-0002Hz-6V for openembedded-core@lists.openembedded.org; Tue, 03 Jul 2012 19:45:55 +0200 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 03 Jul 2012 10:34:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="188049669" Received: from unknown (HELO [10.255.12.182]) ([10.255.12.182]) by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2012 10:34:52 -0700 Message-ID: <4FF32D3B.4030805@linux.intel.com> Date: Tue, 03 Jul 2012 10:34:51 -0700 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: <1341299026-10073-1-git-send-email-dennis.yxun@gmail.com> In-Reply-To: <1341299026-10073-1-git-send-email-dennis.yxun@gmail.com> Subject: Re: [PATCH v3] openjade-native: fix undefined Getopts error, use std namespace X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2012 17:45:55 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 07/03/2012 12:03 AM, Dennis Lan wrote: > Using Gentoo Linux as the build host, it fails without this patch > Use Getopt::Std in place of getopts.pl. > > https://bugs.gentoo.org/show_bug.cgi?id=420083 > > which following error: > /usr/bin/perl -w ./../msggen.pl -l jstyleModule InterpreterMessages.msg > /usr/bin/perl -w ./../msggen.pl -l jstyleModule DssslAppMessages.msg > Undefined subroutine&main::Getopts called at ./../msggen.pl line 22. > make[2]: *** [InterpreterMessages.h] Error 2 > make[2]: *** Waiting for unfinished jobs.... > Undefined subroutine&main::Getopts called at ./../msggen.pl line 22. > make[2]: *** [DssslAppMessages.h] Error 2 > > Signed-off-by: Dennis Lan > --- > .../openjade/openjade-1.3.2/msggen.pl.patch | 44 ++++++++++++++++++++ > .../openjade/openjade-native_1.3.2.bb | 3 +- > 2 files changed, 46 insertions(+), 1 deletions(-) > create mode 100644 meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch > Thanks for fixing up the patch header Merged into OE-Core Thanks Sau! > diff --git a/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch > new file mode 100644 > index 0000000..b47fd46 > --- /dev/null > +++ b/meta/recipes-devtools/openjade/openjade-1.3.2/msggen.pl.patch > @@ -0,0 +1,44 @@ > +commit fcc5b94f118495b1a467edcda6c6f631691c3f69 > +Author: Dennis Lan > +Date: Tue Jul 3 09:25:42 2012 +0800 > + > + openjade: fix undefined Getopts error, use std namespace > + > + Using Gentoo Linux as the build host, it fails without this patch > + Use Getopt::Std in place of getopts.pl. > + > + Upstream-Status: Inappropriate [no upstream] > + Original-Author-By: Mike Gilbert > + Signed-off-by: Dennis Lan > + > +diff --git a/msggen.pl b/msggen.pl > +index 0c33968..2ee3f66 100644 > +--- a/msggen.pl > ++++ b/msggen.pl > +@@ -4,6 +4,7 @@ > + # See the file COPYING for copying permission. > + > + use POSIX; > ++use Getopt::Std; > + > + # Package and version. > + $package = 'openjade'; > +@@ -18,8 +19,7 @@ $gen_c = 0; > + undef $opt_l; > + undef $opt_p; > + undef $opt_t; > +-do 'getopts.pl'; > +-&Getopts('l:p:t:'); > ++getopts('l:p:t:'); > + $module = $opt_l; > + $pot_file = $opt_p; > + > +@@ -72,7 +72,7 @@ while () { > + else { > + $field[0] =~ /^[IWQXE][0-9]$/ ||&error("invalid first field");; > + $type[$num] = substr($field[0], 0, 1); > +- $argc = int(substr($field[0], 1, 1)); > ++ $argc = substr($field[0], 1, 1); > + } > + $nargs[$num] = $argc; > + $field[1] =~ /^[a-zA-Z_][a-zA-Z0-9_]+$/ ||&error("invalid tag"); > diff --git a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb > index 5b29c1f..a539c35 100644 > --- a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb > +++ b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb > @@ -7,13 +7,14 @@ SECTION = "base" > LICENSE = "BSD" > LIC_FILES_CHKSUM = "file://COPYING;md5=641ff1e4511f0a87044ad42f87cb1045" > > -PR = "r4" > +PR = "r5" > > DEPENDS = "opensp-native sgml-common-native" > RDEPENDS_${PN} = "sgml-common-native" > > SRC_URI = "${SOURCEFORGE_MIRROR}/openjade/openjade-${PV}.tar.gz \ > file://makefile.patch \ > + file://msggen.pl.patch \ > file://reautoconf.patch \ > file://user-declared-default-constructor.patch" >