Re: [PATCH] libgomp: add libgomp (openmp) library, and build for powerpc targets by default

[Saul Wold <sgw@linux.intel.com>]

On 07/05/2012 09:32 PM, Matthew McClintock wrote:
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>   meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>   meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>   meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>   3 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
> index 020e21b..32545eb 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
> @@ -1,6 +1,6 @@
>   require gcc-common.inc
>
> -PR = "r25"
> +PR = "r26"
>
>   # Third digit in PV should be incremented after a minor release
>   # happens from this branch on gcc e.g. currently its 4.6.0
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> index 34bfaeb..a7d478c 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>       --with-build-sysroot=${STAGING_DIR_TARGET}"
>
>   RUNTIMETARGET = "libssp libstdc++-v3"
> +RUNTIMETARGET_append_powerpc = " libgomp"
> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>   #  ?
>   # libiberty
>   # libmudflap
> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> index feb8735..001a444 100644
> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> @@ -13,6 +13,8 @@ PACKAGES = "\
>     libgfortran-dev \
>     libmudflap \
>     libmudflap-dev \
> +  libgomp \
> +  libgomp-dev \
>   "
>   # The base package doesn't exist, so we clear the recommends.
>   RRECOMMENDS_${PN}-dbg = ""
> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>     ${libdir}/libmudflap*.a \
>     ${libdir}/libmudflap*.la"
>
> +FILES_libgomp = "${libdir}/libgomp*.so.*"
> +FILES_libgomp-dev = "\
> +  ${libdir}/libgomp*.so \
> +  ${libdir}/libgomp*.a \
> +  ${libdir}/libgomp*.la \
> +  ${libdir}/libgomp.spec \
> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>

I should have noticed this before, but it took a build failure!  Did you 
intend to have a ".a" in the -dev package vs the -staticdav package?

> ERROR: QA Issue: non -staticdev package contains static .a library: libgomp-dev path '/work/ppc603e-poky-linux/gcc-runtime-4.7.1+svnr188658-r2/packages-split/libgomp-dev/usr/lib/libgomp.a'
> ERROR: QA run found fatal errors. Please consider fixing them.
> ERROR: Function failed: do_package_qa
> ERROR: Logfile of failure stored in: /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/gcc-runtime-4.7.1+svnr188658-r2/temp/log.do_package.15360
> NOTE: package gcc-runtime-4.7.1+svnr188658-r2: task do_package: Failed
> ERROR: Task 654 (/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/meta/recipes-devtools/gcc/gcc-runtime_4.7.bb, do_package) failed with exit code '1'

Sau!