Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] package install failure on systems without /sbin/ldconfig
Date: Mon, 09 Jul 2012 21:23:46 -0700	[thread overview]
Message-ID: <4FFBAE52.6070301@linux.intel.com> (raw)
In-Reply-To: <20120709185017.GA22808@windriver.com>

On 07/09/2012 11:50 AM, Amy Fong wrote:
> Package install failures due to issues in post install rules.
>
> package_do_shlibs only looks for libraries in a directory "lib", this should be
> modified to the variable baselib.
>
> ldconfig_postinst_fragment failure observed on systems without /sbin/ldconfig
>          [ -x /sbin/ldconfig ] && /sbin/ldconfig
> results in the post install rule returning a failure. Modify to
>          if [ -x /sbin/ldconfig ]; then /sbin/ldconfig; fi
>
If this is addressing bug #2723, then please mark it as follows:

[YOCTO #2723] in the commit message.

Also the commit subject should include the file name for example:
package.bbclass: fix for package install failure on systems without 
/sbin/ldconfig

Thanks
	Sau!

> Signed-off-by: Amy Fong <amy.fong@windriver.com>
> ---
>   package.bbclass |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 56ab25c..28a263c 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -1151,7 +1151,7 @@ emit_pkgdata[dirs] = "${PKGDESTWORK}/runtime"
>
>   ldconfig_postinst_fragment() {
>   if [ x"$D" = "x" ]; then
> -	[ -x /sbin/ldconfig ] && /sbin/ldconfig
> +	if [ -x /sbin/ldconfig ]; then /sbin/ldconfig ; fi
>   fi
>   }
>
> @@ -1261,7 +1261,7 @@ python package_do_shlibs() {
>   		return
>   		
>   	lib_re = re.compile("^.*\.so")
> -	libdir_re = re.compile(".*/lib$")
> +	libdir_re = re.compile(".*/%s$" % d.getVar('baselib', True))
>
>   	packages = d.getVar('PACKAGES', True)
>   	targetos = d.getVar('TARGET_OS', True)
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>




  reply	other threads:[~2012-07-10  4:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 18:50 [PATCH] package install failure on systems without /sbin/ldconfig Amy Fong
2012-07-10  4:23 ` Saul Wold [this message]
2012-07-10 13:45   ` Amy Fong
2012-07-17 15:52 ` Saul Wold
  -- strict thread matches above, loose matches on Subject: below --
2012-07-09 15:38 Amy Fong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFBAE52.6070301@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox