Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Raymond Danks <ray.danks@se-eng.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2] mkelfimage: Upgrade to e1e6a91
Date: Tue, 10 Jul 2012 09:04:18 -0600	[thread overview]
Message-ID: <4FFC4472.2020403@se-eng.com> (raw)
In-Reply-To: <4FFC43D5.7060708@linux.intel.com>

On 07/10/2012 09:01 AM, Saul Wold wrote:
> On 07/10/2012 07:35 AM, Raymond Danks wrote:
>> Address QA issue: Files/directories were installed but not shipped.
>> New revision contains patch to mkelfimage removing
>> /usr/share/mkelfImage/elf32-i386 directory from Makefile install target.
>>
>> http://review.coreboot.org/#/c/1195/
>>
>> Signed-off-by: Raymond Danks <ray.danks@se-eng.com>
>> ---
>> v2:
>>    Reword commit log
>>
> I hate to do this, but I am looking at the summary and it really does 
> not tell me anything, a better summary would be something like:
>
> mkelfimage: corrected packaging issue in upstream
Saul,

That's basically what the comment said before it was nacked.  I'm not 
attached to the summary or the commit log.  Feel free to do with it what 
you want.

The change to the .bb file fixes the issue.

Thanks,
Ray
>
> ...
>
> Thanks
>     Sau!
>
>>   meta/recipes-devtools/mkelfimage/mkelfimage_git.bb |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb 
>> b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb
>> index 1224a63..4b45c67 100644
>> --- a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb
>> +++ b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb
>> @@ -4,7 +4,7 @@ SECTION = "devel"
>>   LICENSE = "GPLv2"
>>   LIC_FILES_CHKSUM = 
>> "file://COPYING;md5=ea5bed2f60d357618ca161ad539f7c0a"
>>
>> -SRCREV = "e13632a939e7dde8d7d44fc73e73a41dae8060c3"
>> +SRCREV = "e1e6a91ce0738400fa1615179de88ebc0df29f66"
>>   PV = "1.0.0+gitr${SRCPV}"
>>   PR = "r1"
>>
>>
>




  reply	other threads:[~2012-07-10 15:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-09 20:51 [PATCH] mkelfimage: Upgrade to e1e6a91 Raymond Danks
2012-07-09 22:41 ` Khem Raj
2012-07-09 23:03   ` Raymond Danks
2012-07-10  1:22     ` Khem Raj
2012-07-10 14:35 ` [PATCH v2] " Raymond Danks
2012-07-10 15:01   ` Saul Wold
2012-07-10 15:04     ` Raymond Danks [this message]
2012-07-17 15:53 ` [PATCH] " Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FFC4472.2020403@se-eng.com \
    --to=ray.danks@se-eng.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox