public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	Anton Antonov <Anton.Antonov@arm.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core] [langdale][master][PATCH] rust: Do not use default compiler flags defined in CC crate
Date: Sat, 19 Nov 2022 01:57:23 +0000	[thread overview]
Message-ID: <4c2db9a4441a470fb1555b68b6bffb62@axis.com> (raw)
In-Reply-To: <8b2ecf15502e08644ffbc1c7cbea6d3862da68a1.camel@linuxfoundation.org>

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 18 november 2022 17:36
> To: Anton Antonov <Anton.Antonov@arm.com>; openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core] [langdale][master][PATCH] rust: Do not use default compiler flags defined in CC crate
> 
> On Fri, 2022-11-18 at 16:21 +0000, Anton Antonov wrote:
> >   I’ve tested your approach. It doesn’t work for whatever reason.
> > CRATE_CC_NO_DEFAULTS is empty exported for native recipes:
> >
> > $ MACHINE=qemuarm bitbake rust-native -e |grep CRATE_CC_NO_DEFAULTS
> > # $CRATE_CC_NO_DEFAULTS [3 operations]
> > #     [export] "${'1' if d.getVar('CRATE_CC_NO_DEFAULTS') == 'true' else '0'}"
> > export CRATE_CC_NO_DEFAULTS=""
> > # $CRATE_CC_NO_DEFAULTS:class-native
> > CRATE_CC_NO_DEFAULTS:class-native=""
> >
> >
> >   I also tried:
> > CRATE_CC_NO_DEFAULTS[export] = "${@oe.utils.conditional('CRATE_CC_NO_DEFAULTS', '', '0', '1', d)}"
> > with the same result – empty export.
> 
> I think it might need to be 0 or "" instead of '0'. It would be nice if
> we could make False work too but I worry that might not.
> 
> Cheers,
> 
> Richard

None of this will work unless you change the code in bitbake/lib/bb/data.py 
to use d.getVarFlag(var, "export") instead of d.getVarFlag(var, "export", False).
However, I assume that is not wanted given that support for foo[unexport] = "1" 
was introduced to counteract a foo[export] = "1".

//Peter


  parent reply	other threads:[~2022-11-19  1:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-18 14:42 [langdale][master][PATCH] rust: Do not use default compiler flags defined in CC crate Anton Antonov
2022-11-18 15:10 ` [OE-core] " Richard Purdie
2022-11-18 15:27   ` Anton Antonov
2022-11-18 16:21   ` [OE-core] " Anton Antonov
2022-11-18 16:35     ` Richard Purdie
2022-11-18 17:15       ` Anton Antonov
2022-11-19  1:57       ` Peter Kjellerstedt [this message]
2022-11-20 11:45         ` Richard Purdie
2022-11-21  9:39           ` Anton Antonov
2022-12-08 12:17 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c2db9a4441a470fb1555b68b6bffb62@axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=Anton.Antonov@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox