From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Sinan Kaya <okaya@kernel.org>, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [meta-oe][PATCH v2] iproute2: split ip to individual package
Date: Wed, 16 Dec 2020 16:41:12 +0000 [thread overview]
Message-ID: <4c68403b74ca631b1ca2e1c0c11293b7dd4232bd.camel@linuxfoundation.org> (raw)
In-Reply-To: <24b84835-d086-7aec-2f5b-af1313039de6@kernel.org>
On Wed, 2020-12-16 at 11:09 -0500, Sinan Kaya wrote:
> On 12/16/2020 6:50 AM, Richard Purdie wrote:
> > > +++ b/meta/recipes-connectivity/iproute2/iproute2.inc
> > > @@ -46,10 +46,11 @@ do_install () {
> > > # The .so files in iproute2-tc are modules, not traditional
> > > libraries
> > > INSANE_SKIP_${PN}-tc = "dev-so"
> > >
> > > -PACKAGES =+ "\
> > > +IPROUTE2_PACKAGES =+ "\
> > > ${PN}-devlink \
> > > ${PN}-genl \
> > > ${PN}-ifstat \
> > > + ${PN}-ip \
> > > ${PN}-lnstat \
> > > ${PN}-nstat \
> > > ${PN}-rtacct \
> > > @@ -58,12 +59,17 @@ PACKAGES =+ "\
> > > ${PN}-tipc \
> > > "
> > >
> > > +PACKAGES += "${IPROUTE2_PACKAGES}"
> > > +PROVIDES += "${IPROUTE2_PACKAGES}"
> > This doesn't look correct. Why do we need to add all the individual
> > package splits to PROVIDES?
> >
>
> I want to add iproute2-ip into my IMAGE_INSTALL and not take the rest
> of the iproute2-$foo packages. If I don't add PROVIDES, build stage
> fails saying nobody provides iproute2-ip.
IMAGE_INSTALL is a runtime namespace, the same as RPROVIDES/RDEPENDS,
not PROVIDES/DEPENDS so using iproute2-ip there should be fine.
> > or is there some other reason for this? This is basically the issue
> > with some of the other package splits too, its not using the build
> > time verses runtime namespaces correctly.
>
> If I misunderstood something or am not doing it right, let me know.
I think IMAGE_INSTALL should work (behind the scenes it adds to
RDEPENDS for the image).
Cheers,
Richard
next prev parent reply other threads:[~2020-12-16 16:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 2:41 [meta-oe][PATCH v2] iproute2: split ip to individual package Sinan Kaya
2020-12-16 11:50 ` [OE-core] " Richard Purdie
2020-12-16 16:09 ` Sinan Kaya
2020-12-16 16:41 ` Richard Purdie [this message]
[not found] ` <16513E431D142AE6.31352@lists.openembedded.org>
2020-12-16 16:25 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c68403b74ca631b1ca2e1c0c11293b7dd4232bd.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=okaya@kernel.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox