From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: "Burton, Ross" <ross.burton@intel.com>,
Mikko Ylinen <mikko.ylinen@linux.intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] systemd: check 'efi' in MACHINE_FEATURES
Date: Wed, 29 Mar 2017 23:36:23 +0000 [thread overview]
Message-ID: <4cf87faa3852485a820c7526323ef2ab@XBOX02.axis.com> (raw)
In-Reply-To: <CAJTo0LaLhSaC3bx09=qc+gL7YsPKD0YEtukZafUXcxZdW37dwQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
For the record, this is just correcting a regression that was introduced with my change to use bb.utils.filter() where I apparently missed that not all the features were DISTRO_FEATURES…
That said, I do agree that it would be preferable to get rid of the machine specific dependency if possible.
//Peter
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Burton, Ross
Sent: den 29 mars 2017 18:01
To: Mikko Ylinen
Cc: OE-core
Subject: Re: [OE-core] [PATCH] systemd: check 'efi' in MACHINE_FEATURES
On 29 March 2017 at 10:26, Mikko Ylinen <mikko.ylinen@linux.intel.com<mailto:mikko.ylinen@linux.intel.com>> wrote:
The recipe checks 'efi' in DISTRO_FEATURES but it's a machine feature.
Fix the check to use MACHINE_FEATURES to determine whether to
enable/disable 'efi' PACKAGECONFIG.
This makes systemd a MACHINE-specific recipe, and as it contains libudev causes rebuilds for everything linking to that. What's the actual impact of enabling/disabling EFI?
There is a whitelist for recipes which are machine-specific but should be treated as tune, but the barrier to get on that list is high.
Ross
[-- Attachment #2: Type: text/html, Size: 4823 bytes --]
next prev parent reply other threads:[~2017-03-29 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 9:26 [PATCH] systemd: check 'efi' in MACHINE_FEATURES Mikko Ylinen
2017-03-29 16:00 ` Burton, Ross
2017-03-29 23:36 ` Peter Kjellerstedt [this message]
2017-03-30 6:59 ` Mikko Ylinen
2017-03-30 16:15 ` Burton, Ross
2017-03-31 12:00 ` Mikko Ylinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cf87faa3852485a820c7526323ef2ab@XBOX02.axis.com \
--to=peter.kjellerstedt@axis.com \
--cc=mikko.ylinen@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox