From: Joshua Watt <jpewhacker@gmail.com>
To: Ross Burton <ross.burton@intel.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 7/7] oeqa/sdk: add test to exercise Meson
Date: Mon, 07 Jan 2019 10:44:57 -0600 [thread overview]
Message-ID: <4d020a2be7a89c50d6f29cdabc298d7c2bd80de7.camel@gmail.com> (raw)
In-Reply-To: <20190107163823.31816-7-ross.burton@intel.com>
On Mon, 2019-01-07 at 16:38 +0000, Ross Burton wrote:
> (From OE-Core rev: 29359493e391d68a5a6b4fa4d09ffdc1fe6db620)
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/lib/oeqa/sdk/cases/buildepoxy.py | 35
> +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
> create mode 100644 meta/lib/oeqa/sdk/cases/buildepoxy.py
>
> diff --git a/meta/lib/oeqa/sdk/cases/buildepoxy.py
> b/meta/lib/oeqa/sdk/cases/buildepoxy.py
> new file mode 100644
> index 00000000000..ef24b4f4ac1
> --- /dev/null
> +++ b/meta/lib/oeqa/sdk/cases/buildepoxy.py
> @@ -0,0 +1,35 @@
> +import os
> +import subprocess
> +import tempfile
> +import unittest
> +
> +from oeqa.sdk.case import OESDKTestCase
> +from oeqa.utils.subprocesstweak import errors_have_output
> +errors_have_output()
> +
> +class EpoxyTest(OESDKTestCase):
FWIW: I know that is in the same style as the assimp test, but I always
thought the test should have been called the "cmake" test, since that
is what we actually care about (not specifically that it can build
assimp; any cmake package could have been used AFAIK).
Perhaps this should break that trend and be called the "meson" test?
> + """
> + Test that Meson builds correctly.
> + """
> + def setUp(self):
> + if not (self.tc.hasHostPackage("nativesdk-meson")):
> + raise unittest.SkipTest("GalculatorTest class: SDK
> doesn't contain Meson")
> +
> + def test_epoxy(self):
> + with tempfile.TemporaryDirectory(prefix="epoxy",
> dir=self.tc.sdk_dir) as testdir:
> + tarball = self.fetch(testdir, self.td["DL_DIR"], "
> https://github.com/anholt/libepoxy/releases/download/1.5.3/libepoxy-1.5.3.tar.xz
> ")
> +
> + dirs = {}
> + dirs["source"] = os.path.join(testdir, "libepoxy-1.5.3")
> + dirs["build"] = os.path.join(testdir, "build")
> + dirs["install"] = os.path.join(testdir, "install")
> +
> + subprocess.check_output(["tar", "xf", tarball, "-C",
> testdir])
> + self.assertTrue(os.path.isdir(dirs["source"]))
> + os.makedirs(dirs["build"])
> +
> + self._run("meson -Degl=no -Dglx=no -Dx11=false {build}
> {source}".format(**dirs))
> + self._run("ninja -C {build} -v".format(**dirs))
> + self._run("DESTDIR={install} ninja -C {build} -v
> install".format(**dirs))
> +
> + self.check_elf(os.path.join(dirs["install"], "usr",
> "local", "lib", "libepoxy.so"))
> --
> 2.11.0
>
--
Joshua Watt <JPEWhacker@gmail.com>
next prev parent reply other threads:[~2019-01-07 16:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 16:38 [PATCH 1/7] toolchain-scripts: run post-relocate scripts for every environment Ross Burton
2019-01-07 16:38 ` [PATCH 2/7] meson: use a sensible default for libdir when cross-compiling Ross Burton
2019-01-07 16:38 ` [PATCH 3/7] meson: fix nativesdk-meson for multilib SDKs Ross Burton
2019-01-07 19:03 ` Martin Kelly
2019-01-07 20:02 ` Burton, Ross
2019-01-07 20:07 ` Martin Kelly
2019-01-07 16:38 ` [PATCH 4/7] meson: write correct host endian into SDK cross file Ross Burton
2019-01-07 16:38 ` [PATCH 5/7] oeqa/sdk/cases: clean up DL_DIR handling Ross Burton
2019-01-07 16:38 ` [PATCH 6/7] oeqa/sdk/assimp: cleanup Ross Burton
2019-01-07 16:38 ` [PATCH 7/7] oeqa/sdk: add test to exercise Meson Ross Burton
2019-01-07 16:44 ` Joshua Watt [this message]
2019-01-07 16:48 ` Burton, Ross
2019-01-07 17:03 ` ✗ patchtest: failure for "toolchain-scripts: run post-re..." and 6 more Patchwork
2019-01-08 11:01 ` [PATCH 1/7] toolchain-scripts: run post-relocate scripts for every environment Burton, Ross
2019-01-08 13:10 ` Joshua Watt
2019-01-08 13:19 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d020a2be7a89c50d6f29cdabc298d7c2bd80de7.camel@gmail.com \
--to=jpewhacker@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox