public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: richard.purdie@linuxfoundation.org
To: Changqing Li <changqing.li@windriver.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] squashfs-tools: always install prebuilt manpage
Date: Mon, 16 May 2022 11:54:37 +0100	[thread overview]
Message-ID: <4e640d6e43aae9a6be851539f6ddbb7882b82a62.camel@linuxfoundation.org> (raw)
In-Reply-To: <20220516104207.1734099-1-changqing.li@windriver.com>

On Mon, 2022-05-16 at 18:42 +0800, Changqing Li wrote:
> From: Changqing Li <changqing.li@windriver.com>
> 
> When other feature enabled, and involve help2man into squashfs-tools's
> recipe-sysroot-native, install-manpages.sh will run target binary on
> build host, eg: mksquashfs --help, which will cause error.
> Eg:
>  ../squashfs-tools/mksquashfs: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ../squashfs-tools/mksquashfs)
> > help2man: can't get `--help' info from /tmp/tmp.pEG5R8COVb/mksquashfs.sh
> > Try `--no-discard-stderr' if option outputs to stderr
> > ./mksquashfs-manpage.sh: help2man returned error.  Aborting
> > ../generate-manpages/install-manpages.sh: Failed to generate manpage.  Aborting
> 
> Fixed by always install prebuilt manpage, avoid running target binary on
> build host
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>

I'd much prefer not to carry a patch doing this. Which "other feature
enabled" trigger this to happen?

We might want to talk to upstream about making this configurable rather
than carrying a patch, or we make sure help2man is never accessible to
this recipe in some other way.

Cheers,

Richard



  reply	other threads:[~2022-05-16 10:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16 10:42 [PATCH] squashfs-tools: always install prebuilt manpage changqing.li
2022-05-16 10:54 ` richard.purdie [this message]
2022-05-17  2:27   ` [OE-core] " Li, Changqing
2022-05-17  7:32     ` richard.purdie
2022-05-18  1:29       ` Li, Changqing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e640d6e43aae9a6be851539f6ddbb7882b82a62.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=changqing.li@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox