From: Aws Ismail <aws.ismail@windriver.com>
To: oe-core list <Openembedded-core@lists.openembedded.org>
Subject: [PATCH] Fix for psplash segmentation fault
Date: Tue, 17 Jul 2012 12:04:54 -0400 [thread overview]
Message-ID: <50058D26.1060004@windriver.com> (raw)
Fix psplash segmentation fault
This fixes the segmentation fault when calling:
psplash -a
The -a option requires a rotation angle to be given
and if it is missing then the user is shown the correct usage.
Signed-off-by: Aws Ismail <aws.ismail@windriver.com>
diff --git
a/meta/recipes-core/psplash/files/psplash-fix-angle-argv-segfault.patch
b/meta/recipes-core/psplash/files/psplash-fix-angle-argv-s
new file mode 100644
index 0000000..797fe48
--- /dev/null
+++ b/meta/recipes-core/psplash/files/psplash-fix-angle-argv-segfault.patch
@@ -0,0 +1,27 @@
+Fix psplash segmentation fault
+
+This fixes the segmentation fault when calling:
+psplash -a
+
+The -a option requires a rotation angle to be given
+and if it is missing then the user is shown the correct usage.
+
+From: git://git.yoctoproject.org/psplash
+
+Upstream-Status: Submitted
+
+Signed-off-by: Aws Ismail <aws.ismail@windriver.com>
+
+diff --git a/psplash.c b/psplash.c
+index 0158628..09cf0d0 100644
+--- a/psplash.c
++++ b/psplash.c
+@@ -219,7 +219,7 @@ main (int argc, char** argv)
+
+ if (!strcmp(argv[i],"-a") || !strcmp(argv[i],"--angle"))
+ {
+- if (++i > argc) goto fail;
++ if (++i >= argc) goto fail;
+ angle = atoi(argv[i]);
+ continue;
+ }
diff --git a/meta/recipes-core/psplash/psplash_git.bb
b/meta/recipes-core/psplash/psplash_git.bb
index 0d88a60..06f8a9c 100644
--- a/meta/recipes-core/psplash/psplash_git.bb
+++ b/meta/recipes-core/psplash/psplash_git.bb
@@ -11,6 +11,7 @@ PR = "r2"
SRC_URI = "git://git.yoctoproject.org/${BPN};protocol=git \
file://psplash-init \
+ file://psplash-fix-angle-argv-segfault.patch \
${SPLASH_IMAGES}"
SPLASH_IMAGES = "file://psplash-poky-img.h;outsuffix=default"
next reply other threads:[~2012-07-17 19:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-17 16:04 Aws Ismail [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-17 16:37 [PATCH] Fix for psplash segmentation fault Aws Ismail
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50058D26.1060004@windriver.com \
--to=aws.ismail@windriver.com \
--cc=Openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox