From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com ([134.134.136.20]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SrtmH-0001Vp-Al for openembedded-core@lists.openembedded.org; Thu, 19 Jul 2012 18:40:37 +0200 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 19 Jul 2012 09:28:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="168549968" Received: from srifenb-mobl.amr.corp.intel.com (HELO envy.home) ([10.7.199.145]) by orsmga001.jf.intel.com with ESMTP; 19 Jul 2012 09:28:53 -0700 Message-ID: <50083564.3020200@linux.intel.com> Date: Thu, 19 Jul 2012 09:27:16 -0700 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Richard Purdie References: <5005BFA6.5050809@linux.intel.com> <5005C134.4080805@linux.intel.com> <1342714551.7940.15.camel@ted> In-Reply-To: <1342714551.7940.15.camel@ted> X-Enigmail-Version: 1.4.3 Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/1] EFI: Make installer EFI aware X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2012 16:40:37 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 07/19/2012 09:15 AM, Richard Purdie wrote: > On Tue, 2012-07-17 at 12:47 -0700, Darren Hart wrote: >> >> On 07/17/2012 12:40 PM, Saul Wold wrote: >>> On 07/17/2012 12:29 PM, Darren Hart wrote: >> >>>> --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb >>>> +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb >>>> @@ -3,7 +3,7 @@ DESCRIPTION = "Small image capable of booting a device. The kernel includes \ >>>> the Minimal RAM-based Initial Root Filesystem (initramfs), which finds the \ >>>> first “init” program more efficiently." >>>> >>>> -IMAGE_INSTALL = "initramfs-live-boot initramfs-live-install busybox udev base-passwd" >>>> +IMAGE_INSTALL = "initramfs-live-boot initramfs-live-install initramfs-live-install-efi busybox udev base-passwd" >>>> >>>> # Do not pollute the initrd image with rootfs features >>>> IMAGE_FEATURES = "" >>> >>> Does this now need a PR bump also? >> >> I didn't think so as this recipe is rebuilt for every image anyway. >> There is no PR in this recipe. >> >>>> diff --git a/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb >>>> new file mode 100644 >>>> index 0000000..6696d94 >>>> --- /dev/null >>>> +++ b/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb >>>> @@ -0,0 +1,22 @@ >>>> +DESCRIPTION = "A live image init script for grub-efi" >>>> +LICENSE = "MIT" >>>> +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420" >>>> +SRC_URI = "file://init-install-efi.sh" >>>> + >>>> +PR = "r7" >>>> + >>> Why PR = r7 for a new recipe, there should be no PR as it defaults to r0? >> >> Good catch, just my forcing rebuilds during development, or perhaps a >> left-over copy from the initramfs-live-install_1.0.bb I based it on. >> Updated as r0 in the branch. > > Could I ask you to update this on top of Radu's fix please? Will do. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel