From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com ([192.55.52.88]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SwFND-0005ek-EV for openembedded-core@lists.openembedded.org; Tue, 31 Jul 2012 18:32:43 +0200 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 31 Jul 2012 09:21:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="191243676" Received: from unknown (HELO envy.home) ([10.255.13.49]) by fmsmga001.fm.intel.com with ESMTP; 31 Jul 2012 09:21:04 -0700 Message-ID: <50180584.4030305@linux.intel.com> Date: Tue, 31 Jul 2012 09:19:16 -0700 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: <1343747440-31885-1-git-send-email-raj.khem@gmail.com> In-Reply-To: X-Enigmail-Version: 1.4.3 Subject: Re: [PATCH] kernel.bbclass: Preserve generated headers X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2012 16:32:43 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 07/31/2012 08:16 AM, Bruce Ashfield wrote: > On Tue, Jul 31, 2012 at 11:10 AM, Khem Raj wrote: >> asm/unistd.h includes asm/unistd_64.h on x86_64 >> and asm/unistd_32.h on i386 but these files are >> generated files in 3.4 and when we do 'make clean' they get >> deleted and it shows up as an error when building >> external modules. May be its a 3.4 kernel bug may be not >> but make clean should have left the tree in >> a shape to build modules but it does not. >> >> Probably we should run make modules_prepare after having >> run make clean. >> >> Signed-off-by: Khem Raj >> --- >> meta/classes/kernel.bbclass | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >> index b19ed4c..4ac3d48 100644 >> --- a/meta/classes/kernel.bbclass >> +++ b/meta/classes/kernel.bbclass >> @@ -197,6 +197,8 @@ kernel_do_install() { >> if [ -f include/generated/bounds.h ]; then >> cp include/generated/bounds.h $kerneldir/include/generated/bounds.h >> fi >> + mkdir -p $kerneldir/arch/${ARCH}/include/generated/ >> + cp -fR arch/${ARCH}/include/generated/* $kerneldir/arch/${ARCH}/include/generated/ > > If we take the blanket protection, we should be able to drop the > bounds.h specific > case a the same time .. right ? No, different dirs (one is ARCH) > > I'm ok with this, but I can run a test with 'make modules_prepare' > being run if you > already haven't. We really can't, this builds scripts, which we don't want as this results in native binaries being installed on the target :( We need some cross-build-system-friendly make targets for this. > > Cheers, > > Bruce > >> >> # Remove the following binaries which cause strip or arch QA errors >> # during do_package for cross-compiled platforms >> -- >> 1.7.5.4 >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel