From: Darren Hart <dvhart@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] kernel.bbclass: Preserve generated headers
Date: Tue, 31 Jul 2012 09:44:31 -0700 [thread overview]
Message-ID: <50180B6F.8050906@linux.intel.com> (raw)
In-Reply-To: <CADkTA4O4c=F8FR67adWZyiZ5kOAqbB7bmjRMCsGEctgiwYK_FA@mail.gmail.com>
On 07/31/2012 09:31 AM, Bruce Ashfield wrote:
> On Tue, Jul 31, 2012 at 12:19 PM, Darren Hart <dvhart@linux.intel.com> wrote:
>>
>>
>> On 07/31/2012 08:16 AM, Bruce Ashfield wrote:
>>> On Tue, Jul 31, 2012 at 11:10 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>>> asm/unistd.h includes asm/unistd_64.h on x86_64
>>>> and asm/unistd_32.h on i386 but these files are
>>>> generated files in 3.4 and when we do 'make clean' they get
>>>> deleted and it shows up as an error when building
>>>> external modules. May be its a 3.4 kernel bug may be not
>>>> but make clean should have left the tree in
>>>> a shape to build modules but it does not.
>>>>
>>>> Probably we should run make modules_prepare after having
>>>> run make clean.
>>>>
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>> meta/classes/kernel.bbclass | 2 ++
>>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>>> index b19ed4c..4ac3d48 100644
>>>> --- a/meta/classes/kernel.bbclass
>>>> +++ b/meta/classes/kernel.bbclass
>>>> @@ -197,6 +197,8 @@ kernel_do_install() {
>>>> if [ -f include/generated/bounds.h ]; then
>>>> cp include/generated/bounds.h $kerneldir/include/generated/bounds.h
>>>> fi
>>>> + mkdir -p $kerneldir/arch/${ARCH}/include/generated/
>>>> + cp -fR arch/${ARCH}/include/generated/* $kerneldir/arch/${ARCH}/include/generated/
>>>
>>> If we take the blanket protection, we should be able to drop the
>>> bounds.h specific
>>> case a the same time .. right ?
>>
>> No, different dirs (one is ARCH)
>
> Aha. I missed that, but can we back up a directory and take everything from
> generated/* ? .. assuming your question about binaries being in those
> directory is "no".
It isn't a "no" for the include/generated dir, just not sure about ARCH.
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Technical Lead - Linux Kernel
next prev parent reply other threads:[~2012-07-31 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 15:10 [PATCH] kernel.bbclass: Preserve generated headers Khem Raj
2012-07-31 15:16 ` Bruce Ashfield
2012-07-31 16:19 ` Darren Hart
2012-07-31 16:31 ` Bruce Ashfield
2012-07-31 16:44 ` Darren Hart [this message]
2012-07-31 16:18 ` Darren Hart
2012-08-08 14:36 ` Khem Raj
2012-08-16 18:22 ` Saul Wold
2012-08-16 18:50 ` Saul Wold
2012-08-20 16:57 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50180B6F.8050906@linux.intel.com \
--to=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox