From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx0-f175.google.com ([209.85.213.175]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Sxjic-0004x1-8p for openembedded-core@lists.openembedded.org; Sat, 04 Aug 2012 21:08:58 +0200 Received: by yenm12 with SMTP id m12so24034yen.6 for ; Sat, 04 Aug 2012 11:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=0pel6AIZixfh4U0w5wa52gVSZPa+DyYZNxl6HrJ+sNA=; b=g/6EMxS4S7fwUosRQ92vN+67KxNV63et1xlBWbPRGai/qaCvjVF+w5hdEH3Mn7zzAL aZKNvWJPH0gFFmwQneRW0RZIai6cNtNr61Hy/lI2kJb+Us8rorbJ8FYLYn5noVOZnXa4 y9Fz+OdtRSUyvLkrIbP4ry368x7AAQPnG1VsSI+Hzi1qV6KNSkUdkxEov/raPN1n8VnW GRAVsM5w2houLoYixBuGpcuTjNYiMfAyq8Cj8WWKrm1lWZ+4nbM/AW4aTte7x1S8JIie pVW3d2ldgWmOt3jGDV0RxQ4b6GeRhQKfjxs5zxuq9lI0c8s2+kLqe9O15MqCkzVmN/TW VubA== Received: by 10.50.173.39 with SMTP id bh7mr1670285igc.44.1344106634888; Sat, 04 Aug 2012 11:57:14 -0700 (PDT) Received: from [192.168.1.111] (S0106586d8f4832af.tb.shawcable.net. [24.109.142.27]) by mx.google.com with ESMTPS id wm7sm4296427igb.6.2012.08.04.11.57.13 (version=SSLv3 cipher=OTHER); Sat, 04 Aug 2012 11:57:14 -0700 (PDT) Message-ID: <501D7090.2040500@gmail.com> Date: Sat, 04 Aug 2012 14:57:20 -0400 From: Derek Buitenhuis User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: openembedded-core@lists.openembedded.org References: <1343942157-15997-1-git-send-email-yao.zhao@windriver.com> In-Reply-To: <1343942157-15997-1-git-send-email-yao.zhao@windriver.com> X-Enigmail-Version: 1.4.3 Subject: Re: [PATCH] gstreamer: gst-ffmpeg: fix build issues for libav X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Aug 2012 19:08:58 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 02/08/2012 5:15 PM, Yao Zhao wrote: > 1.The included libav configure is not generated by autotools > patch use-correct-toolchain.patch patched its configure to > use correct toolchain wrapper. Why are you patching the toolchain instead of passing the correct parameters to configure (--enable-cross-compile, --cross-prefix-..., etc)? > 2.add bzip2 dependency explicitly. > or configure will detect whether libbz2 is installed, if bzip2 > is triggered earlier then it will be detected, if not then won't Looks OK. > 3.detect whether toolchain supports altivec, if not then add > disable-altivec to libav's configure line or configure will fail Wrong fix. http://git.libav.org/?p=libav.git;a=blob;f=configure;h=b139008d2b1aa5faea3f33c2a1922d0e1cb1fa5c;hb=HEAD#l2318 It should be fixed by passing the proper CPU to libav's configure as an argument. > 4.move the GSTREAMER_DEBUG to libav's configure, it is not the > option for the main configure. OK. - Derek