From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail1.windriver.com ([147.11.146.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1T3TSn-0000yf-LU for openembedded-core@lists.openembedded.org; Mon, 20 Aug 2012 17:00:22 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail1.windriver.com (8.14.5/8.14.3) with ESMTP id q7KEmGiC005104 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 20 Aug 2012 07:48:16 -0700 (PDT) Received: from [128.224.146.67] (128.224.146.67) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.309.2; Mon, 20 Aug 2012 07:48:15 -0700 Message-ID: <50324E29.5060005@windriver.com> Date: Mon, 20 Aug 2012 10:48:09 -0400 From: Bruce Ashfield User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Liang Li References: <1344348160.9756.255.camel@ted> <20120808033742.GA19078@localhost> <20120814021712.GB25748@localhost> <502D12E2.4000808@windriver.com> <1345132684.14667.70.camel@ted> <20120817033209.GB19625@localhost> <1345196146.14667.84.camel@ted> <20120817100001.GA16621@localhost> <1345200782.26132.18.camel@ted> <20120817130151.GA1416@localhost> <20120817130517.GB1416@localhost> In-Reply-To: <20120817130517.GB1416@localhost> Cc: darren.hart@intel.com, openembedded-core@lists.openembedded.org Subject: Re: [discussion] perf: specify SLANG_INC dir for perf X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2012 15:00:22 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 12-08-17 09:05 AM, Liang Li wrote: > On 2012-08-17 21:01, Liang Li wrote: >> On 2012-08-17 18:53, Richard Purdie wrote: >>> On Fri, 2012-08-17 at 18:00 +0800, Liang Li wrote: >>>> I am totally confused, you mentioned 'general kernel do_install', I >>>> assume it's oe-core kernel.bbclass concept. Then you mentioned 'get >>>> the fix upstream in the mainline kernel', how could that happen? >>>> >>>> We are discussing about the solution to 'fix the compile warning to >>>> error' stuff that triggered by the '-I/usr/include/slang', right? >>> >>> Yes. >>> >>>> We do not necessarily have to change recipe to fix it since the issue >>>> is not introduced by the recipe, the hard coded '-I/usr/include/slang' >>>> in the Makefile cause the issue, we can fix the root cause by kernel >>>> patch(other than just comment the line out). I see your previous patch >>>> to kernel, by comment out the '-I/usr/include/slang' line in the >>>> Makefile, is the same behavior, but we won't have the change(comment >>>> out -I.. in Makefile) upstream to mainline, right? >>> >>> I am suggesting that firstly, someone send a patch to the mainline >>> kernel which changes -I/usr/include/slang to -I=/usr/include/slang in >>> that Makefile. >>> >>> Secondly, I'm suggesting that we add a line to kernel_do_install() in >>> kernel.bbclass which does a sed on the Makefile as installed into >>> $kerneldir which changes -I/usr/include/slang to -I=/usr/include/slang. >>> >>> We can then drop the patch I added to the linux-yocto kernels. >>> >>> This is all that should be needed, it should fix all the issues people >>> have reported in a way that is acceptable to everyone. >>> >> >> Ah, I see what you mean now. But we have push acceptable kernel patch > One final (I hope) follow up on this. Liang: were you going to put together (and test) the 'sed fix' for kernel.bbclass ? I have my own set of issues that are consuming my time now, and I want to ensure that this doesn't fall through the cracks, since we need a full/real fix for this as soon as possible. Cheers, Bruce > Sorry, I mean 'we can ...' instead of 'we have ...', just typo.