Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Marc Reilly <marc@cpdesign.com.au>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [Patch V2] avahi: fix packaging of avahi-autoipd
Date: Mon, 20 Aug 2012 09:06:45 -0700	[thread overview]
Message-ID: <50326095.7020209@linux.intel.com> (raw)
In-Reply-To: <1345248270-21796-1-git-send-email-marc@cpdesign.com.au>

On 08/17/2012 05:04 PM, Marc Reilly wrote:
> - Avahi's "avahi-autoipd" file is in the dhcp/ folder, not dhcp3/
> - udhcpc files were being installed but not being shipped in avahi-autoipd
> - do_install override for avahi-autoipd was not being called and is not
>    required, so join it into regular do_install.
> - While at it, fixup string quoting in description.
>
> This makes avahi-autoipd work with simple ifup/down scripts.
>
> Signed-off-by: Marc Reilly <marc@cpdesign.com.au>
> ---
>   meta/recipes-connectivity/avahi/avahi.inc |   11 +++++------
>   1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/meta/recipes-connectivity/avahi/avahi.inc b/meta/recipes-connectivity/avahi/avahi.inc
> index 37ff70d..c08acb5 100644
> --- a/meta/recipes-connectivity/avahi/avahi.inc
> +++ b/meta/recipes-connectivity/avahi/avahi.inc
> @@ -1,10 +1,10 @@
>   SUMMARY = "Avahi IPv4LL network address configuration daemon"
> -DESCRIPTION = "Avahi is a fully LGPL framework for Multicast DNS Service Discovery. It \
> +DESCRIPTION = 'Avahi is a fully LGPL framework for Multicast DNS Service Discovery. It \
>   allows programs to publish and discover services and hosts running on a local network \
>   with no specific configuration. This tool implements IPv4LL, "Dynamic Configuration of \
>   IPv4 Link-Local Addresses" (IETF RFC3927), a protocol for automatic IP address \
>   configuration from the link-local 169.254.0.0/16 range without the need for a central \
> -server."
> +server.'
>   AUTHOR = "Lennart Poettering <lennart@poettering.net>"
>   HOMEPAGE = "http://avahi.org"
>   BUGTRACKER = "http://avahi.org/report"
> @@ -63,7 +63,9 @@ PACKAGES =+ "avahi-systemd avahi-daemon libavahi-common libavahi-core libavahi-c
>   FILES_avahi-systemd = "${systemd_unitdir}"
>   FILES_avahi-autoipd = "${sbindir}/avahi-autoipd \
>                          ${sysconfdir}/avahi/avahi-autoipd.action \
> -                       ${sysconfdir}/dhcp3/*/avahi-autoipd"
> +                       ${sysconfdir}/dhcp/*/avahi-autoipd \
> +                       ${sysconfdir}/udhcpc.d/00avahi-autoipd \
> +                       ${sysconfdir}/udhcpc.d/99avahi-autoipd"
>   FILES_libavahi-common = "${libdir}/libavahi-common.so.*"
>   FILES_libavahi-core = "${libdir}/libavahi-core.so.*"
>   FILES_avahi-daemon = "${sbindir}/avahi-daemon \
> @@ -116,10 +118,7 @@ do_install() {
>   	rm -rf ${D}/var/run
>   	rm -rf ${D}${datadir}/dbus-1/interfaces
>   	rm -rf ${D}${libdir}/avahi
> -}
>
> -do_install_avahi-autoipd() {
> -	autotools_do_install
>   	install -d ${D}${sysconfdir}/udhcpc.d
>   	install ${WORKDIR}/00avahi-autoipd ${D}${sysconfdir}/udhcpc.d
>   	install ${WORKDIR}/99avahi-autoipd ${D}${sysconfdir}/udhcpc.d
>

Merged into OE-Core

Thanks
	Sau!




      reply	other threads:[~2012-08-20 16:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-18  0:04 [Patch V2] avahi: fix packaging of avahi-autoipd Marc Reilly
2012-08-20 16:06 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50326095.7020209@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=marc@cpdesign.com.au \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox