From: Andy Ross <andy.ross@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@openembedded.org
Subject: Re: [PATCH 2/2] libtool: normalize link paths before considering for RPATH
Date: Mon, 20 Aug 2012 09:59:20 -0700 [thread overview]
Message-ID: <50326CE8.6090206@windriver.com> (raw)
In-Reply-To: <1345370811.27428.86.camel@ted>
On 08/19/2012 03:06 AM, Richard Purdie wrote:
> On Fri, 2012-08-17 at 08:53 -0700, Andy Ross wrote:
>> ++ libdir_norm=`echo $libdir \
>> ++ | sed 's/\/\+\.\(\/\+\|$\)/\//g' \
>> ++ | sed 's/[^\/]\+\/\+\.\.\(\/\+\|$\)//g' \
>> ++ | sed 's/\/\+/\//g' \
>> ++ | sed 's/\(.\)\/$/\1/g'`
>
> Can't we use func_norm_abspath here?
I have to admit I got a little confused reading that code (not that my
sed mess is significantly better, but at least I trust it because I
wrote it); but it looks to me like it's an abspath implementation on
the host filesystem (not the use of `pwd` in a few places). That will
work for pruning in this case, since the problem case is already an
absolute path to a host directory. But I don't see how it won't in
principle break things by expanding host paths.
Andy
next prev parent reply other threads:[~2012-08-20 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 15:53 [PATCH 0/2] RPATH host pollution fixes Andy Ross
2012-08-17 15:53 ` [PATCH 1/2] insane.bbclass: Fix RPATH warning in the face of funny path strings Andy Ross
2012-08-17 15:53 ` [PATCH 2/2] libtool: normalize link paths before considering for RPATH Andy Ross
2012-08-19 10:06 ` Richard Purdie
2012-08-20 16:59 ` Andy Ross [this message]
2012-08-20 21:55 ` Richard Purdie
2012-08-17 16:20 ` [PATCH 1/2] insane.bbclass: Fix RPATH warning in the face of funny path strings Richard Purdie
2012-08-20 21:05 ` [PATCH] " Andy Ross
2012-08-21 15:49 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50326CE8.6090206@windriver.com \
--to=andy.ross@windriver.com \
--cc=openembedded-core@openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox