From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1T3f78-0006F9-2W for openembedded-core@lists.openembedded.org; Tue, 21 Aug 2012 05:26:46 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id q7L3EfxP022846 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 20 Aug 2012 20:14:41 -0700 (PDT) Received: from [128.224.162.170] (128.224.162.170) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.309.2; Mon, 20 Aug 2012 20:14:40 -0700 Message-ID: <5032FD1F.7030805@windriver.com> Date: Tue, 21 Aug 2012 11:14:39 +0800 From: jhuang0 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer , Martin Jansa References: <20120817121307.GG3625@jama.jama.net> In-Reply-To: <20120817121307.GG3625@jama.jama.net> Subject: Re: [PATCH 1/1] apr-util: fix the rules.mk with path to sysroot instead of the workdir of apr X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2012 03:26:46 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 8/17/2012 8:13 PM, Martin Jansa wrote: > On Fri, Aug 17, 2012 at 11:11:43AM +0800, jackie.huang@windriver.com wrote: >> From: Jackie Huang >> >> The copying for rules.mk was happened in do_configure_prepend, but it will be >> replaced by the one generated by configure, in which APR_MKEXPORT points to >> the workdir of apr and cause compile filure when the workdir of apr is removed. >> So change the copying in _prepend to _append. >> >> [YOCTO #2947] >> >> Signed-off-by: Jackie Huang >> --- >> meta/recipes-support/apr/apr-util_1.4.1.bb | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/meta/recipes-support/apr/apr-util_1.4.1.bb b/meta/recipes-support/apr/apr-util_1.4.1.bb >> index deb608f..0516bc4 100644 >> --- a/meta/recipes-support/apr/apr-util_1.4.1.bb >> +++ b/meta/recipes-support/apr/apr-util_1.4.1.bb >> @@ -32,8 +32,10 @@ inherit autotools lib_package binconfig >> >> OE_BINCONFIG_EXTRA_MANGLE = " -e 's:location=source:location=installed:'" >> >> -do_configure_prepend() { >> - cp ${STAGING_DATADIR}/apr/apr_rules.mk ${S}/build/rules.mk >> +do_configure_append() { >> + if [ "${PN}" == "${BPN}" ]; then >> + cp ${STAGING_DATADIR}/apr/apr_rules.mk ${S}/build/rules.mk >> + fi >> } >> do_configure_prepend_virtclass-native() { >> cp ${STAGING_DATADIR_NATIVE}/apr/apr_rules.mk ${S}/build/rules.mk > > Why is it different then native case above? > The bug didn't happen in native case since the related paths in rules.mk generated by configure for apr-util-native were pointed to the correct dirs in sysroot, so this fix is only applied for BPN. And I checked that what makes this difference is the different 'location' in apr-1-config of BPN and native one: $ diff intel-atom/usr/bin/crossscripts/apr-1-config x86_64-linux/usr/bin/apr-1-config | tail -n 4 49c49 < location=source --- > location=installed Thanks, Jackie > Shouldn't be the same fix prepend/append applied for native case too and > then "${PN}" == "${BPN}" won't be needed? > > Cheers, > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > -- Jackie Huang WIND RIVER | China Development Center MSN:jackielily@hotmail.com Tel: +86 8477 8594 Mobile: +86 138 1027 4745