From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com ([192.55.52.93]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1T4C0x-000820-N7 for openembedded-core@lists.openembedded.org; Wed, 22 Aug 2012 16:34:35 +0200 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 22 Aug 2012 07:22:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.77,808,1336374000"; d="scan'208";a="212350918" Received: from dell-desktop (HELO [10.237.105.32]) ([10.237.105.32]) by fmsmga002.fm.intel.com with ESMTP; 22 Aug 2012 07:22:28 -0700 Message-ID: <5034EBB3.3010906@intel.com> Date: Wed, 22 Aug 2012 17:24:51 +0300 From: Radu Moisan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120714 Thunderbird/14.0 MIME-Version: 1.0 To: Chris Larson References: <1345632209-4188-1-git-send-email-radu.moisan@intel.com> In-Reply-To: Cc: openembedded-core@lists.openembedded.org Subject: Re: [PATCH] coreutils: Upgrade to upstream version 8.17 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2012 14:34:35 -0000 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/22/2012 05:08 PM, Chris Larson wrote: > On Wed, Aug 22, 2012 at 3:43 AM, Radu Moisan wrote: >> diff --git a/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch b/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch >> new file mode 100644 >> index 0000000..e32f612 >> --- /dev/null >> +++ b/meta/recipes-core/coreutils/coreutils-8.17/realpath-works-yes.patch >> @@ -0,0 +1,21 @@ >> +Signed-off-by: Radu Moisan >> +Upstream status: pending >> + >> +The new version of coreutils, adds use of canonicalize_file_name() function defined in canonicalize.h >> +The problem: the function is redefined to rpl_canonicalize_file_name by means of a macro,which gives >> +an undefined reference error at compile time. Macro definition depends in the end on >> +gl_cv_func_realpath_works but assumed true only when set to "yes" >> + >> +Index: coreutils-8.17/m4/canonicalize.m4 >> +=================================================================== >> +--- coreutils-8.17.orig/m4/canonicalize.m4 2012-05-08 12:05:23.000000000 +0300 >> ++++ coreutils-8.17/m4/canonicalize.m4 2012-08-17 14:20:22.000000000 +0300 >> +@@ -95,7 +95,7 @@ >> + [gl_cv_func_realpath_works=no], >> + [case "$host_os" in >> + # Guess yes on glibc systems. >> +- *-gnu*) gl_cv_func_realpath_works="guessing yes" ;; >> ++ *-gnu*) gl_cv_func_realpath_works="yes" ;; >> + # If we don't know, assume the worst. >> + *) gl_cv_func_realpath_works="guessing no" ;; >> + esac > Wouldn't it be better to provide a cached test result in the site > files for this test, rather than relying on a host_os based guess? I really don't know the answer to your question. The patch was intended to provide minimally invasive change to the original file. If you elaborate more on your proposal, I would gladly take into consideration a future patch to address this issue. radu