From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1T4kbP-0005LF-1a for openembedded-core@lists.openembedded.org; Fri, 24 Aug 2012 05:30:31 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail.windriver.com (8.14.5/8.14.3) with ESMTP id q7O3ILnl013959 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 23 Aug 2012 20:18:21 -0700 (PDT) Received: from [128.224.163.178] (128.224.163.178) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.2.309.2; Thu, 23 Aug 2012 20:18:21 -0700 Message-ID: <5036F27B.2050906@windriver.com> Date: Fri, 24 Aug 2012 11:18:19 +0800 From: jhuang0 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: <5e873b2c99606b089ed82777f64049837a30beb0.1343032359.git.jackie.huang@windriver.com> <1343037628.21788.83.camel@ted> <500E2FFF.2050202@windriver.com> In-Reply-To: <500E2FFF.2050202@windriver.com> Cc: "Zhao, Zhenfeng" , "Yang, Liezhi" Subject: Re: [PATCH 1/1] quota 4.00: add DEPENDS gettext-native X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2012 03:30:31 -0000 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 7/24/2012 1:17 PM, jhuang0 wrote: > > > On 7/23/2012 6:00 PM, Richard Purdie wrote: >> On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote: >>> From: Jackie Huang >>> >>> do_install needs command 'msgfmt', it would fail if the command >>> doesn't exist on the host, add DEPENDS gettext-native to fix this. >>> >>> [YOCTO #2811] >>> >>> Signed-off-by: Jackie Huang >>> --- >>> meta/recipes-extended/quota/quota_4.00.bb | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/meta/recipes-extended/quota/quota_4.00.bb >>> b/meta/recipes-extended/quota/quota_4.00.bb >>> index 5fef9cb..25f6381 100644 >>> --- a/meta/recipes-extended/quota/quota_4.00.bb >>> +++ b/meta/recipes-extended/quota/quota_4.00.bb >>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = >>> "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f >>> >>> S = "${WORKDIR}/quota-tools" >>> >>> +DEPENDS = "gettext-native" >>> + >>> inherit autotools >>> >>> EXTRA_OEMAKE += 'STRIP=""' >> >> Shouldn't this be "inherit gettext" ? > > No, quota doesn't depend on gettext at runtime, so I don't think we need > 'inherit gettext'. quota only needs command 'msgfmt' which provied by gettext in do_install, so I don't think we need 'inherit gettext' to both depends on gettext-native and virtual/gettext. Could anyone explain why we should use 'inherit gettext' instead of just depending on gettext-native? Thanks, Jackie > > Thanks, > Jackie > >> >> Cheers, >> >> Richard >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> > -- Jackie Huang WIND RIVER | China Development Center MSN:jackielily@hotmail.com Tel: +86 8477 8594 Mobile: +86 138 1027 4745