Re: [PATCH 1/4] runqemu: Honor KERNEL and ROOTFS settings from environment

[Scott Garman <scott.a.garman@intel.com>]

On 08/22/2012 10:59 AM, Khem Raj wrote:
> Expand the usage to be able to specify KERNEL and ROOTFS
> on commandline. This helps in using the script for booting
> images that are essentially not part of OE-Core
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

Sure, this looks okay.

Acked-by: Scott Garman <scott.a.garman@intel.com>

> ---
>   scripts/runqemu |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index 90998ae..290f9cc 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -54,9 +54,9 @@ error() {
>   }
>
>   MACHINE=${MACHINE:=""}
> -KERNEL=""
> +KERNEL=${KERNEL:=""}
> +ROOTFS=${ROOTFS:=""}
>   FSTYPE=""
> -ROOTFS=""
>   LAZY_ROOTFS=""
>   SCRIPT_QEMU_OPT=""
>   SCRIPT_QEMU_EXTRA_OPT=""
>


-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center