Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] libiconv: skip recipe if using eglibc
Date: Fri, 24 Aug 2012 11:26:09 -0700	[thread overview]
Message-ID: <5037C741.4070107@linux.intel.com> (raw)
In-Reply-To: <1345468841-12320-1-git-send-email-paul.eggleton@linux.intel.com>

On 08/20/2012 06:20 AM, Paul Eggleton wrote:
> libiconv is provided for use with uClibc - if you build it together with
> eglibc (which already PROVIDES virtual/libiconv) you can end up with
> dependency problems during do_rootfs.
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
>   meta/recipes-support/libiconv/libiconv_1.11.1.bb |    5 +++++
>   meta/recipes-support/libiconv/libiconv_1.14.bb   |    5 +++++
>   2 files changed, 10 insertions(+)
>
> diff --git a/meta/recipes-support/libiconv/libiconv_1.11.1.bb b/meta/recipes-support/libiconv/libiconv_1.11.1.bb
> index 186a5a1..055e20d 100644
> --- a/meta/recipes-support/libiconv/libiconv_1.11.1.bb
> +++ b/meta/recipes-support/libiconv/libiconv_1.11.1.bb
> @@ -20,6 +20,11 @@ S = "${WORKDIR}/libiconv-${PV}"
>
>   inherit autotools pkgconfig gettext
>
> +python __anonymous() {
> +    if d.getVar("TCLIBC", True) == "eglibc":
> +        raise bb.parse.SkipPackage("libiconv is provided for use with uClibc only - eglibc already provides iconv")
> +}
> +
>   EXTRA_OECONF += "--enable-shared --enable-static --enable-relocatable"
>
>   LEAD_SONAME = "libiconv.so"
> diff --git a/meta/recipes-support/libiconv/libiconv_1.14.bb b/meta/recipes-support/libiconv/libiconv_1.14.bb
> index af33d6b..6666866 100644
> --- a/meta/recipes-support/libiconv/libiconv_1.14.bb
> +++ b/meta/recipes-support/libiconv/libiconv_1.14.bb
> @@ -21,6 +21,11 @@ S = "${WORKDIR}/libiconv-${PV}"
>
>   inherit autotools pkgconfig gettext
>
> +python __anonymous() {
> +    if d.getVar("TCLIBC", True) == "eglibc":
> +        raise bb.parse.SkipPackage("libiconv is provided for use with uClibc only - eglibc already provides iconv")
> +}
> +
>   EXTRA_OECONF += "--enable-shared --enable-static --enable-relocatable"
>
>   LEAD_SONAME = "libiconv.so"
>

Merged into OE-Core

Thanks
	Sau!




      parent reply	other threads:[~2012-08-24 18:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-20 13:20 [PATCH] libiconv: skip recipe if using eglibc Paul Eggleton
2012-08-20 19:22 ` Khem Raj
2012-08-24 18:26 ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5037C741.4070107@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox