From: Saul Wold <sgw@linux.intel.com>
To: Martin Ertsaas <mertsas@cisco.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] rsync: Add md5sum and sha256sum for the rsync_2.6.9
Date: Thu, 06 Sep 2012 12:03:29 -0700 [thread overview]
Message-ID: <5048F381.1090202@linux.intel.com> (raw)
In-Reply-To: <1346939964-24426-1-git-send-email-mertsas@cisco.com>
On 09/06/2012 06:59 AM, Martin Ertsaas wrote:
> rsync_2.6.9 is the only rsync recipe in openembedded without GPLv3 license, but it lacked the
> checksums for the fetcher.
> ---
> meta/recipes-devtools/rsync/rsync_2.6.9.bb | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/meta/recipes-devtools/rsync/rsync_2.6.9.bb b/meta/recipes-devtools/rsync/rsync_2.6.9.bb
> index 54feada..8c8b115 100644
> --- a/meta/recipes-devtools/rsync/rsync_2.6.9.bb
> +++ b/meta/recipes-devtools/rsync/rsync_2.6.9.bb
> @@ -10,6 +10,9 @@ SRC_URI = "http://rsync.samba.org/ftp/rsync/src/rsync-${PV}.tar.gz \
> file://rsync-2.6.9-fname-obo.patch \
> file://rsyncd.conf"
>
> +SRC_URI[md5sum] = "996d8d8831dbca17910094e56dcb5942"
> +SRC_URI[sha256sum] = "ca437301becd890e73300bc69a39189ff1564baa761948ff149b3dd7bde633f9"
> +
> inherit autotools
>
> do_install_append() {
>
It's a good fix, but you need a Signed-off-by: in the commit message please.
Thanks
Sau!
prev parent reply other threads:[~2012-09-06 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 13:59 [PATCH] rsync: Add md5sum and sha256sum for the rsync_2.6.9 Martin Ertsaas
2012-09-06 19:03 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5048F381.1090202@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=mertsas@cisco.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox