From: Saul Wold <sgw@linux.intel.com>
To: Ross Burton <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] xserver-xorg: make DRI/GLX options respect opengl distro feature
Date: Mon, 10 Sep 2012 08:37:59 -0700 [thread overview]
Message-ID: <504E0957.104@linux.intel.com> (raw)
In-Reply-To: <1346791451-23638-1-git-send-email-ross.burton@intel.com>
On 09/04/2012 01:44 PM, Ross Burton wrote:
> If the distro doesn't have the opengl feature there's no point building the DRI
> or GLX support, making the mesa-dri build dependency optional.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc | 3 +--
> meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc | 5 ++++-
> meta/recipes-graphics/xorg-xserver/xserver-xorg.inc | 6 ------
> 3 files changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> index b588c11..b4a348c 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-1.11.2.inc
> @@ -8,5 +8,4 @@ SRC_URI += "file://crosscompile.patch \
> SRC_URI[md5sum] = "8796fff441e5435ee36a72579008af24"
> SRC_URI[sha256sum] = "fa415decf02027ca278b06254ccfbcceba2a83c2741405257ebf749da4a73cf2"
>
> -PR = "r5"
> -
> +PR = "r6"
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> index 404c488..94e83ea 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg-common.inc
> @@ -119,8 +119,11 @@ EXTRA_OECONF += "--with-fop=no \
> ac_cv_file__usr_share_sgml_X11_defs_ent=no \
> "
>
> -PACKAGECONFIG ??= "udev"
> +PACKAGECONFIG ??= "udev ${@base_contains('DISTRO_FEATURES', 'opengl', 'glx', '', d)}"
> PACKAGECONFIG[udev] = "--enable-config-udev,--disable-config-udev,udev"
> +PACKAGECONFIG[glx] = "--enable-dri --enable-dri2 --enable-glx --enable-glx-tls,\
> + --disable-dri --disable-glx,\
> + xf86driproto dri2proto mesa-dri"
>
> do_install_append () {
> # Its assumed base-files creates this for us
> diff --git a/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc b/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
> index ca7d33a..1322cfc 100644
> --- a/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
> +++ b/meta/recipes-graphics/xorg-xserver/xserver-xorg.inc
> @@ -1,12 +1,6 @@
> require xserver-xorg-common.inc
>
> -PROTO_DEPS += "xf86driproto dri2proto"
> -LIB_DEPS += "mesa-dri"
> -
> EXTRA_OECONF += "\
> - --enable-dri \
> - --enable-dri2 \
> - --enable-glx-tls \
> --with-pic \
> --with-int10=x86emu \
> --without-xmlto \
>
Merged into OE-Core
Thanks
Sau!
next prev parent reply other threads:[~2012-09-10 15:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 20:44 [PATCH] xserver-xorg: make DRI/GLX options respect opengl distro feature Ross Burton
2012-09-10 15:37 ` Saul Wold [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-07 10:49 Ross Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504E0957.104@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox