From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES
Date: Tue, 11 Sep 2012 10:53:45 -0500 [thread overview]
Message-ID: <504F5E89.4070504@windriver.com> (raw)
In-Reply-To: <504F5A7C.9070407@linux.intel.com>
On 9/11/12 10:36 AM, Saul Wold wrote:
> On 09/11/2012 08:13 AM, Richard Purdie wrote:
>> On Tue, 2012-09-11 at 08:07 -0700, Saul Wold wrote:
>>> This will allow the KERNEL_FEATURES to trigger the x32 ABI via overrides
>>>
>>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>>> ---
>>> meta/conf/machine/include/ia32/arch-ia32.inc | 1 +
>>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/conf/machine/include/ia32/arch-ia32.inc b/meta/conf/machine/include/ia32/arch-ia32.inc
>>> index 15f67d7..fa70e57 100644
>>> --- a/meta/conf/machine/include/ia32/arch-ia32.inc
>>> +++ b/meta/conf/machine/include/ia32/arch-ia32.inc
>>> @@ -24,6 +24,7 @@ ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "x32", "" ,d)}"
>>> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-mx32", "", d)}"
>>> TUNE_LDARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-m elf32_x86_64", "", d)}"
>>> TUNE_ASARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-x32", "", d)}"
>>> +MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", ":x32", "" ,d)}"
>>>
>>> # ELF64 ABI
>>> TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI"
>>
>> This is just for the kernel issue, right?
>>
>> In that case, just use ${@bb.utils.contains("TUNE_FEATURES", "mx32",
>> "xxxx", "" ,d)} in the kernel recipe code...
>>
> It's possible that there will be other recipes that need patches or
> other changes in the future, but I guess we can cross that bridge when
> we come to it.
>
> I think I will actually use the features update that Bruce just added
> from here instead. Since multiple BSP could take advantage of x32 we
> should not have to edit each of there kernel recipes. It should just be
> enabled based on the x32 DEFAULTTUNE.
I know there are a few other things that can (and should) change behavior based
on the x32 flag.. but flag or override, it just changes slightly the
implementation mechanism -- either should work as long as we consistently use it.
--Mark
> Thanks
> Sau!
>
>
>
>> Cheers,
>>
>> Richard
>>
>>
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2012-09-11 16:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 15:07 [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES Saul Wold
2012-09-11 15:13 ` Richard Purdie
2012-09-11 15:36 ` Saul Wold
2012-09-11 15:53 ` Mark Hatle [this message]
2012-09-11 15:56 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504F5E89.4070504@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox