Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Mark Asselstine <mark.asselstine@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] kernel: remove unused 'etc' directory
Date: Wed, 12 Sep 2012 11:20:05 -0700	[thread overview]
Message-ID: <5050D255.9030401@linux.intel.com> (raw)
In-Reply-To: <1347457260-25574-1-git-send-email-mark.asselstine@windriver.com>


I assume this patch is for Denzil?  It seems that the current OE-Core 
master has etc in that list.

Please confirm

Sau!

On 09/12/2012 06:41 AM, Mark Asselstine wrote:
> Along with checks to remove empty modprobe.d and modules-load.d
> directories we can add a similar check and removal of the etc
> directory. This will avoid warnings by the sanity checker.
>
> Signed-off-by: Mark Asselstine <mark.asselstine@windriver.com>
> CC: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
>
> There is some concern that removing this directory could cause issues
> if folks are adding to etc in a bbappend and not checking for and
> creating this directory. I don't believe this is an issue as if you
> want to add something to etc it should be done as part of a
> populate_packages_prepend or earlier since there are sanity checks run
> as part of populate_packages, so the removal here is being done at the
> latest possible point in the process (populate_packages_prepend in a
> bbappend will run before the populate_packages_prepend in
> kernel.bbclass).
>
>   meta/classes/kernel.bbclass |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 5e04fda..decf6f5 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -468,7 +468,7 @@ python populate_packages_prepend () {
>       # avoid warnings. removedirs only raises an OSError if an empty
>       # directory cannot be removed.
>       dvar = d.getVar('PKGD', True)
> -    for dir in ["%s/etc/modprobe.d" % (dvar), "%s/etc/modules-load.d" % (dvar)]:
> +    for dir in ["%s/etc/modprobe.d" % (dvar), "%s/etc/modules-load.d" % (dvar), "%s/etc/" % (dvar)]:
>           if len(os.listdir(dir)) == 0:
>               os.rmdir(dir)
>
>



  reply	other threads:[~2012-09-12 18:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-12 13:41 [PATCH] kernel: remove unused 'etc' directory Mark Asselstine
2012-09-12 18:20 ` Saul Wold [this message]
2012-09-12 19:35   ` Mark Asselstine
2012-09-18 16:39     ` Scott Garman
2012-09-18 18:04       ` Mark Asselstine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5050D255.9030401@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=mark.asselstine@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox